Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Firelocks are no longer pryable by hand if they are powered #1837

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Revert "Firelocks are no longer pryable by hand if they are powered #1837

merged 1 commit into from
Sep 17, 2024

Conversation

deltanedas
Copy link
Member

About the PR

you can now pry firelocks without a crowbar

Why / Balance

  • this did nothing in the event of spacing and power loss, which is extremely common
  • this led to everything taking crowbars immediately because (brave statement) they dont want to get murdered by a powered firelock
  • since everyone takes a crowbar, this had no effect on the powergamers but punished people that dont take them, in the case of fires by round removing them
  • nobody enjoys getting killed by firelocks. not a single person

Changelog
🆑

  • tweak: You no longer need a crowbar to pry powered firelocks open.

@deltanedas deltanedas requested a review from a team September 16, 2024 20:04
@deltanedas deltanedas requested a review from a team as a code owner September 16, 2024 20:04
@MilonPL
Copy link
Contributor

MilonPL commented Sep 16, 2024

holy based

@TadJohnson00
Copy link
Contributor

Would it be possible to just comment out a line of C# here instead of fully reverting? If we do end up planning anything major with space wind or depressurisation, having the code would still be nice.

@deltanedas
Copy link
Member Author

could just add a return yeah :trollface:

TadJohnson00
TadJohnson00 approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@TadJohnson00 TadJohnson00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Direction approved 😎

@deltanedas deltanedas merged commit 82c2fe6 into DeltaV-Station:master Sep 17, 2024
11 checks passed
@deltanedas deltanedas deleted the firelock-ops branch September 17, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TadJohnson00 TadJohnson00 TadJohnson00 approved these changes

Assignees
No one assigned
Labels
Changes: C# Changes any cs files Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deltanedas @MilonPL @TadJohnson00