The Resprite: Diagonal Reinforced Wall, Greyscale Decal Cleanup, Secret Doors #1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Canisters * Liquid * Update meta.json * Update gas_canisters.yml * Update meta.json * Fix * Create gas_canisters.yml * Update gas_canisters.yml * Update gas_canisters.yml
* Diagonal walls and window * added notice board and diagonal window * diagonal plasma windows * secret door * notice boards are craftable * kegs * keggers * added kegs to boozeomat inventory * Adressing the issues * Delete Resources/Prototypes/_NF/Recipes/Construction/Graphs/structure… * Delete Resources/Prototypes/_NF/Recipes/Construction/wallmount_notice… * Update boozeomat.yml * window parenting fixes * Cleanup * Fixing * added new entity to use as a parent instead of WallSolidDiagonal (whi… * Update diagonal_walls.yml * Merge branch 'new-frontiers-14:master' into Diagonal-Walls&Windows * moving diagonal windows and grille to separate PR * Merge remote-tracking branch 'origin/master' into pr/757 * Merge branch 'new-frontiers-14:master' into Diagonal-Walls&Windows
…ormal walls yaml so there's no dupe
ghost
requested review from
github-actions
bot
added
Status: Needs Review
Changes: YML
|
RSI Diff Bot; head commit 94ce831 merging into 137eccc Resources/Textures/DeltaV/Decals/Overlays/greyscale.rsi
Resources/Textures/_NF/Structures/Doors/secret_door_reinforced.rsi
Resources/Textures/_NF/Structures/Doors/secret_door_shuttle.rsi
Resources/Textures/_NF/Structures/Doors/secret_door_uranium.rsi
Resources/Textures/_NF/Structures/Doors/secret_door_wood.rsi
Resources/Textures/_NF/Structures/Walls/solid_reinforced_diagonal.rsi
Resources/Textures/_NF/Structures/Walls/uranium_diagonal.rsi
Resources/Textures/_NF/Structures/Walls/wood_diagonal.rsi
|
|
Me personally? I'd love if this could get split into separate PRs |
|
I'll split the tanks into a seperate PR, and the walls / decals / door assembly can stay here >:) |
added 2 commits
September 17, 2024 03:17
ghost
changed the title
|
I rember 😔 |
|
Wood tiles get Dir. approval |
|
There is nothing secret about the secret doors TJ. BUT WHAT ABOUT THE DECALS?!!??!?!?!!!??!?!??!111 |
|
Decals fine x3 |
TadJohnson00
approved these changes
Sep 18, 2024
|
Yeah, pretty much. What harm could it do? |
|
@adeinitas We actually made more edits to the walls to allow walls to combine with other walls, did you grab the last changes to the files? |
|
No! I am doing that now, because oh fuck, oh shit!! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Fixed some wooden tiles (Aikakakah did it, blame them.)
Pulled the diagonal walls from them, and as collateral, got a shit-ton of secret doors. From new-frontiers-14/frontier-station-14#757
Fixed decal offsetting on the new sprites, because there were a bunch of old ones clashing with the normal ones.
Why / Balance
I got annoyed at a bunch of little spriting discrepancies and I've decided that I needed to take Noct's resprite project under my wing so forward things I need to do to me. I have a hefty list.
Technical details
A lot of RSIs, YAML.
Media
Requirements
Breaking changes
Changelog
🆑 Adei, ErhardSteinhauer, Aikakakah