Remove nukies axe plating prying capabilities.

[Radezolid]

About the PR

Removed the ability to pry plating as I think the intent behind #1700 was to make only the atmos (and bridge) axe being able to pry plating.

Why / Balance

Nukies are going back to the old meta of carrying the axe spacing every room they are in with it.

Technical details

I inverted the inheritance so the nukie fire axe doesn't get the Axing tag.

Media

Before

2024-09-17.02-05-55.mp4

After

2024-09-17.01-51-36.mp4

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

I hope none.

Changelog

🆑

• fix: Nuclear operatives fire axe is no longer able to pry plating.

[Radezolid]

Insight on why the YAML Linter test failed would be appreciated. The part it complains about was not modified

[deltanedas]

you are completely mangling upstream files without even putting comments

[ghost]

1. Deltanedas was straight to the point about it, but yes. Worth it to comment things and document what you have changed so that if there's suddenly a merge to add functionality to fireaxes it doesn't explode in the upstream merge

2. The reason why the yaml linter is choking is because, if I had to guess with my currently tired brain, the fields for that aren't defined to go with the flaming fireaxe (the parents of that item are baseitem and base engi contra), and swapping the inheritance may not be this simple. It'd be easier to do this in a different way, but it might be more trouble than it's worth 🤷

[TadJohnson00]

I'm gonna let Adei take the lead on trying to address the YAML side of all this. As for the Direction side, can't promise this is gonna sail, will get back to you on whether this'll go through or not.

[Radezolid]

1. Deltanedas was straight to the point about it, but yes. Worth it to comment things and document what you have changed so that if there's suddenly a merge to add functionality to fireaxes it doesn't explode in the upstream merge

   2. The reason why the yaml linter is choking is because, if I had to guess with my currently tired brain, the fields for that aren't defined to go with the flaming fireaxe (the parents of that item are baseitem and base engi contra), and swapping the inheritance may not be this simple. It'd be easier to do this in a different way, but it might be more trouble than it's worth 🤷

Thanks for the corrections, still learning this. If able what would be the different way? Make a new yml just for the nukie one?

I'm gonna let Adei take the lead on trying to address the YAML side of all this. As for the Direction side, can't promise this is gonna sail, will get back to you on whether this'll go through or not.

Sure thing, I was about to make a issue about the axe, but I tried my hand at it.

[deltanedas]

can you not just do qualities: [] to disable it for fire axe

[Radezolid]

can you not just do qualities: [] to disable it for fire axe

Tested it, worked perfectly, I should have done that. Thanks, as I said still learning this.

[ghost]

can you not just do qualities: [] to disable it for fire axe

Tested it, worked perfectly, I should have done that. Thanks, as I said still learning this.

Was gonna suggest making an abstract fire axe and then parenting the atmos and nukie fire axes to this, but I guess this works, so well done.

[ghost]

Deltanedas, unrequest your change and merge it, it's one of the things where I can't

.