Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust security loadouts #1854

Merged
19 commits merged into from
Sep 21, 2024
Merged

Adjust security loadouts #1854

19 commits merged into from
Sep 21, 2024

Conversation

TadJohnson00
Copy link
Contributor

@TadJohnson00 TadJohnson00 commented Sep 18, 2024

About the PR

Add warden and HoS alternate uniforms to their loadouts.
Add adv. plate carriers to warden and HoS lockers.
Remove some jumpsuits from HoS loadout and dresser.
Replace HoS and warden outerwear with Delta-V equivalents in their loadouts, lockers, dressers.
Replace corpsman survival box with standard security survival box.
Add spare empty webbing to corpsman locker.
Comment out corpsman glasses pending discussion.
Add spare headsets to det and corpsman lockers.
Replace detective head, neck, and outer options with security standard in their loadout.
Remove wizden clothing items from detective's locker and drobe.
Add detective clothing items to drobe along with forensic pads and other new paraphernalia.
Remove wizden armour from security loadouts.
Replace wizden security coat with Delta-V version in security loadouts.
Remove security star from loadouts.
Remove spare jumpsuits from security lockers.
Add senior jumpskort. Yes that's spelled correctly. Don't ask me to explain.
Adjust item weights in security lockers.
Adjust secdrobe catalog.

Why / Balance

Direction and content incongruence.

Technical details

Lots of YAML.

Media

image
...the rest is pretty much as it appears in code.

Requirements

Breaking changes

Changelog

🆑

  • tweak: Adjusts security loadouts and lockers. Notable changes include moving detective clothing to the Rep and Autodrobes.
  • add: Advanced plate carriers have been added for the warden and head of security and are located in their lockers.
  • tweak: Several security clothing items have been resprited, including winter boots and winter clothes.

@github-actions github-actions bot added the Changes: YML Changes any yml files label Sep 18, 2024
@TadJohnson00 TadJohnson00 marked this pull request as ready for review September 18, 2024 10:24
@TadJohnson00 TadJohnson00 requested a review from a team as a code owner September 18, 2024 10:24
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yum. The net removal of content.
I have words in the review (not really useful ones, just noting things) but otherwise this looks like normal loadouts yaml and commenting / uncommenting of files. Before I approve, I want to make sure this is a good idea because I can envision all security players seething at The Net Removal Of Content ™️

Here's the things I and others take issue with:

  1. Why is the gold star being removed from the loadout? I think that's just a fun playtime marker thing for if you've played too much security. Literal gold star.
  2. Why are the security winter boots being removed from the loadout? Secoffs on Glacier will get snow in their normal station issued shoes or jackboots / combat boots. It's so sad. There's also some removal of winter coats - what if I'm a lizard on glacier, and I'm HoS, and there's no mapped-in coats? What do I do?
  3. Why can't we keep the noir detective stuff from Wiz, and why do you keep trying to 1984 it? People have issues with that, if you have issues, it could be resprited. I know you explained this to me in my DMs before, but I want you to say it in front of the class (read: people looking at the Delta-V repo.)
  4. Why is the clownsec thing being removed? That's the secdrobe's contra inventory, as blitz has mentioned. I think it'd be funny for it to stay there in the narrow situation someone hacks to get that.

Copy link
Contributor

@BlitzTheSquishy BlitzTheSquishy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somethings here are actually worse than i thought, too much removed, recommend replacing at the same time

@ghost
Copy link

ghost commented Sep 18, 2024

Thanks Blitz for making this have more than just my eyes on it 😸

@Yousifb26
Copy link
Contributor

I’d go on a long rant but the majority of it was said by adei and blitz. I am not a fan of the removal of this much content without nearly as many things to take its place. As stated previously, net removal of content is bad and will make a lot of people upset.

@TadJohnson00
Copy link
Contributor Author

  1. Security star

  2. Security winter boots

2.5 Security coats

  1. Noir gear

  2. Clownsec mask

  1. Why and for what purpose? We already have senior jumpsuit + PDA, I don't find that having a silly sticker is particularly appealing

  2. If someone wants to resprite these they're more than welcome to.

2.5 Good point I'll map them into the HoS and Warden dressers

  1. Anachronistic, for a start. Second off, we're attempting to combat the hard boiled detective trope. Thirdly, detective might not even stay a security role, longer term. So we'll see if they even keep any of the security gear

  2. Contraband slots in the vending machines is... something, for sure. But there's no reason why they'd ever be stocked in here in the first place - hence removal.

@MilonPL
Copy link
Contributor

MilonPL commented Sep 18, 2024

  1. Contraband slots in the vending machines is... something, for sure. But there's no reason why they'd ever be stocked in here in the first place - hence removal.

Why would any vending machine be stocked with contraband? Should we just remove that game mechanic now? Maybe it was a janitor syndicate agent from a previous shift? Maybe a cargo tech added a little extra to the restock? It's up to the players and whatever story they make up for it.

@TadJohnson00
Copy link
Contributor Author

TadJohnson00 commented Sep 18, 2024

Why would any vending machine be stocked with contraband?

Some valid reasons. Will address on a case by case basis.

@ghost ghost added Status: Do Not Merge Don't merge this yet Status: Needs Discussion Must be discussed labels Sep 18, 2024
Add winter coats to HoS and warden dressers
Add sterile mask box to corpsman locker. Just in case.
Readd spacelaw book
Readd spacelaw books
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that sufficient discussion has been had and concessions have been made appropriately. I will let TJ sleep on this and think of the feedback in his dreams, and if it's the same when he wakes up, then it's fine. If it's not, that's fine too.

@MilonPL
Copy link
Contributor

MilonPL commented Sep 18, 2024

I think that sufficient discussion has been had and concessions have been made appropriately. I will let TJ sleep on this and think of the feedback in his dreams, and if it's the same when he wakes up, then it's fine. If it's not, that's fine too.

I think more input wouldn't hurt. We have the rather unused Discussions page on Github. Or someone could make a thread for it too in the discord, because not everyone has a git account. If we want to avoid the previous security resprite scenario, it'd be nice to actually ask the community first. PRs don't need to be speedmerged, it can wait a week.

@BlitzTheSquishy
Copy link
Contributor

I think that sufficient discussion has been had and concessions have been made appropriately. I will let TJ sleep on this and think of the feedback in his dreams, and if it's the same when he wakes up, then it's fine. If it's not, that's fine too.

I think more input wouldn't hurt. We have the rather unused Discussions page on Github. Or someone could make a thread for it too in the discord, because not everyone has a git account. If we want to avoid the previous security resprite scenario, it'd be nice to actually ask the community first. PRs don't need to be speedmerged, it can wait a week.

This is one of the entire reasons why I believe Game Directors should be discussing with the community like staff (though very rarely) were prior to their existance.

@HTMLSystem
Copy link
Contributor

As someone within the community, I also do NOT like the removal of this much stuff. I'm not even someone that plays sec (yet), but this is just. Ridiculious, in my opinion.

  • As someone who's main characters are trans women who wear junpskirts to avoid feeling dysphoric, the removal of the Senior Officer Jumpskirt is a bit ridiculious and I feel like it reduces player freedom. Why is the feminine option suddenly removed when they're a senior officer? What if someone wants to have a GNC character be a senior officer? What if someone's character just likes wearing jumpskirts?? I feel like this change restricts player freedom.
  • Why not have both clothing options for the detective? Have a "hard-boiled" detective isn't a bad thing. Again, you're just restricting player freedom. The clothes people wear matters to a lot of players.
  • We should not be removing items because they need a resprite??? Especially ones that have a mechanic like keeping you warm. That's how we go without security winter boots for months or even a year, because everyone forgot the PR and/or no one's motivated to do it.
  • Why are Warden and HoS getting the winter jackets removed from the loudouts, but not the other heads? That's a bit inconsistent and I know some sec players are going to feel frustrated with it or they'll feel like sec is being targeted for some reason.
  • What's wrong with a silly gold star? I think it's good to have small, silly things in the game. Maybe the officer has some deep inner child-like wonder/hope that they represent through this tiny star. Maybe the secoff just likes the star. We shouldn't be removing things just because they're "silly" or because there's already other options. These "silly" options could be given meaning by the player.
    And those are my opinions. Idk if I covered everything, but I hope this does not get merged and TJ gets in touch with the community about this. I feel like if it was merged, it would cause a bit of a riff within the community.

@perryprog
Copy link
Contributor

A few thoughts, though I think I'm partially repeating what most people have said at this point:

  • Regarding the contraband inventory on vending machines, I think there is a point to be made about there needing to be motivation for why it's there, but I think this is also something that can be player supplied like Milon suggested. I know there's at least one instance where it's explicit, which is the multitool in the YouTool contraband inventory being "left behind" by an engineer doing maintenance on it or something like that. I can think of a few ways a clown mask could (somewhat plausibly) end up in the vending machine under an unlisted option. I would additionally argue that—yes, even in MRP—some amount of difficult to find silly bits of content is okay, but I can go both ways on that belief.
  • The silly sticker is appealing because it's silly. Again, there's decent justification for its existence that can be player-decided. (NanoTrasen having an incentive program to work in security with the top tier being... an entire sticker is what I first think of, and I think that's pretty plausible and amusing.)
  • Like HTMLSystem said, I'm rather confused about the justification of removal for some things like jumpskirts.
  • I understand where you're coming from in regards to not wanting to push the availability of anachronistic tropes like the noir detective too hard, but I'm not seeing the harm in having the relevant items at least being an option in the drobe as it does give good player freedom. Maybe someone wants to play a detective who is obsessed with old-timey detective books and wants to replicate that in their real-life job. I do admit that yes, it is weird that the drobe would have those available in general (why would NanoTrasen spend money on manufacturing anachronistic clothing), but that applies to a good number of things. (Clowns and mimes come to mind, and various anachronistic clothing like pirate garb is also floating around, even if that's not "officially" from NanoTrasen.)

@Alyx-Wander
Copy link

  1. Security star
  2. Security winter boots

2.5 Security coats

  1. Noir gear
  2. Clownsec mask
1. Why and for what purpose? We already have senior jumpsuit + PDA, I don't find that having a silly sticker is particularly appealing

2. If someone wants to resprite these they're more than welcome to.

2.5 Good point I'll map them into the HoS and Warden dressers

3. Anachronistic, for a start. Second off, we're attempting to combat the hard boiled detective trope. Thirdly, detective might not even stay a security role, longer term. So we'll see if they even keep any of the security gear

4. Contraband slots in the vending machines is... something, for sure. But there's no reason why they'd ever be stocked in here in the first place - hence removal.

I actually have some complaints as well, and maybe a few suggestions.

  1. Security Star
    I think we can get away with this by rebranding it to "Deputy's star". It's a common trope in westerns for people to get deputised into a posse, and this might be a way for veteran security officers to do something like that. Let it be an item that security gives out to others, with questionable legitimacy as to whether it actually gives someone any rights as a security officer when they're not hired as one.
    The description could probably read:
    "Given to those who've earned the trust of the Security Department. Make sure you earn it."

  2. Noir Gear
    It is, at the end of the day, clothes. It is an anachronistic look even today, but I don't think that warrants it's removal as I don't think it takes away too much from immersion. It can be worn seriously as well as in jest, and also ironically. It's a bit of a genre staple too. Also, I don't think Detective potentially getting moved away from Security is a reason to get rid of the outfit now.

@deltanedas
Copy link
Member

Thirdly, detective might not even stay a security role, longer term. So we'll see if they even keep any of the security gear

should keep in mind upstream tried this for a bit then ultimately reverted it fwiw

something nobodys mentioned about det gear is that the funny noir trenchcoat is instantly recognizable as a detective, making det a renamed secoff will just dilute the role even more

@TadJohnson00
Copy link
Contributor Author

* Senior Officer Jumpskirt

The new senior officer uniform, unlike the other uniforms, is a "true jumpsuit"; a one piece siren suit, boilersuit, or set of coveralls that minimises snags and covers a majority of the body. Uniforms featuring skirts are still available in red, grey, and blue for security personnel.

* Why not have both clothing options for the detective? The clothes people wear matters to a lot of players.

On the contrary, and as previously mentioned, it's anachronistic and we've additionally elected to avoid the hard boiled detective trope. If people want to dress up as a noir detective, they'll be very much welcome to do so outside the security department.

* We should not be removing items because they need a resprite. That's how we go without security winter boots for months or even a year, because everyone forgot the PR and/or no one's motivated to do it.

We will be removing the winter boots until they are resprited, either by myself or by someone who cares enough to do it before I get around to it. If people really care about the winter boots so little that no one can be bothered to adjust them by the time I do, I don't really know what the fuss about them is anyway.

* Why are Warden and HoS getting the winter jackets removed from the loudouts, but not the other heads? That's a bit inconsistent and I know some sec players are going to feel frustrated with it _or_ they'll feel like sec is being targeted for some reason.

The Warden and HoS are having their winter jackets replaced. They will still have winter options available in both their loadouts and their dressers.

* I think it's good to have small, silly things like the gold star in the game. They can be given meaning by the player.

Sure. We could rename it to just "gold star" and move it to the trinkets section, make it accessible to all roles.

* Regarding the contraband inventory on vending machines, I think there's points on both sides.

Sure. If you've got an adequately convincing reason why NanoTrasen would happen to stock "security-clown masks" in its vendors and restock boxes, I'd be willing to hear it out.

* The silly sticker is appealing _because_ it's silly.

As mentioned previously regarding "the reason is funny and only funny" I don't think this is adequate to keep the security star as it is. That being said, I wouldn't mind moving it to the Trinkets category and having it be accessible to all roles.

* Like HTMLSystem said, I'm rather confused about the justification of removal for some things like jumpskirts.

The main removal here is the removal of the senior officer jumpskirt, which happens to be accompanied by a resprite of the senior officer jumpsuit. As mentioned previously, the senior officer uniform will be a "true jumpsuit".
The only other skirts I can think of being removed are some of the older HoS clothing options, for which reasons have been supplied previously.

* I understand avoiding anachronistic tropes like the noir detective, but I don't see the harm in having the items be an option in the drobe for player freedom. I admit that yes, it _is_ weird that the drobe would have those available in general, but that applies to a good number of things. (Clowns and mimes come to mind, and various anachronistic clothing like pirate garb is also floating around, even if that's not "officially" from NanoTrasen.)

Much like you said, it doesn't make sense for the detective to have such items stocked in their drobe. Even beyond that, having highly curated and quality content is the ideal over variety leading to disparity, anachronism, and incongruence.

   I think we can get away with this by rebranding the security star to "Deputy's star", and can be used to questionably deputise people into posses.

It's a nice idea, but ultimately we're not looking to start normalising any more anachronistic tropes as seen in spaghetti westerns and the like. Also, this smells like another license to validhunt.

   The noir gear may be an anachronistic look even today, but it can be worn seriously as well as in jest, and also ironically.

True points indeed, and completely valid if the detective weren't a part of security - but they are, and the noir gear doesn't fit. Maybe we'll see a return of some of the noir characteristics if they're removed from security.

something nobodys mentioned about det gear is that the funny noir trenchcoat is instantly recognizable as a detective, making det a renamed secoff will just dilute the role even more

"Recognisable as a detective" isn't a major priority. Everyone who needs to know who the detective is (security, mostly) will already know who the detective is. And the only thing changing about the detective is their clothes, if they're a renamed secoff now it's because they always were.

@perryprog
Copy link
Contributor

Thanks for taking the time to reply to that all :). I think I'm pretty convinced by what you've said now, so I'd have no (major) complaints if this were merged.

Regarding the clown mask, I think my favorite head canon that I've had for it is that NanoTrasen tried an unsuccessful program where clowns were made part of security to reduce the negative stigma of how security looks. It failed horribly (obviously) and the equipment from it was disabled in the vend.

@HTMLSystem
Copy link
Contributor

I still don't like a majority of the changes. I think taking away the winter boots just because you wanna resprite them is a bit unnecessary, I think removing the senior officer jumpskirt for a "true jumpsuit" is unnecessary, and just. All the other stuff. I feel like you're restricting some player freedom here, and it doesn't make me feel very hopeful.
I think making a community poll would be the best decision before changing anything.

@ThataKat
Copy link
Contributor

Just giving my two cents as a community member here.

Adjusting content to be more realistic in some regards is not a bad idea, but I think a lot of players may be blindsided by these changed and not understand the intentions behind them. Barring that, many players may not be satisfied with the justification of realism for removing what they perceive as expressive choices for their characters.

I'm honestly a bit surprised that the established position is to remove the anachronistic aspects of the detective. Not because it's a terrible idea, but because this is the first I've heard of that conclusion as a community member, and it already seems so set in stone. It might be a nice thing to bring up and at least get wider feedback on.
On a personal note I don't foresee detective leaving sec because of the numerous problems that causes sec's ability to function, so I'm not sure we should rely on that.

As for the removal of the senior officer jumpskirt, the logic that the new jumpsuit is a "true jumpsuit" seems reasonable to me, but I still worry that no matter the basis in realism, players will still feel restricted. At the end of the day, it is still a video game. I know the argument being made here is not only for realism, but I predict that's how it could come off to players.
It's good to bring up that plenty of skirt options are still available for sec, but it may just confuse players further as to why the senior officer suit has to be bound by true jumpsuit rules.

tl;dr I don't disagree with the logic but as a community member these changes did/will surprise me a bit

@TadJohnson00
Copy link
Contributor Author

Out here wasting my damn Thursday afternoon

Why does everything on Delta-V need to be replaced with a Delta-V version?

Server identity, intended direction, balance, other reasons. Use your imagination.

I am completely happy with how the loadouts are right now.

Okay, hate to be the one to break it to you, but the way the loadouts are right now happen to be broken. If you want WizDen's loadouts, sprites, and items, I hear they have several game servers you could try. If you want Delta-V loadouts, sprites and items, well, they're here.

Why are you removing the upstream security armour?

Long time ago, we removed the upstream armour in favour of specialised body armours. They were readded to Delta-V in loadouts by mistake, due to an oversight when originally porting the loadout system. The fact that they haven't been removed already is kinda crazy.

There are eight removals in this PR. That's not good, in my opinion.

Actually, there's a few more than eight, and you're welcome to that opinion.

Detective is going to get standard security gear and just look like another officer.

No, the detective will be receiving a unique jumpsuit and will have the rest of their important gear.

Didn't we try something similar months before and people hated it?

Yes, but it wasn't reverted for that reason only. And it's true that some people hate this PR. I've been doing and am continuing to do my best to address valid criticism and complaints where they arise, but unfortunately my role isn't the thankless job of making everybody happy, it's the thankless job of directing Delta-V's content. Well, technically I only have to do one half of that job anyways.

I hope you guys don't merge this with the amount of negative reactions it's received.

See previous.

We should have more loadout options. We're here to have fun seeking escapism.

"We need to trim down our loadouts" isn't the rationale behind the majority of the removals. As for the escapism, I can understand that some people just want mindless fun. Unfortunately, that's not really the direction for Delta-V, as we are moving towards solidifying the server as a medium-roleplay space, but there are definitely other places you can go to for looser content direction and the like.

If you're removing the donuts and the security-clown mask you may as well remove every contraband from every other vendor.

As stated previously, will address this on a case-by-case basis.

Why did you remove the corpsman glasses?

Briefly addressed this earlier, let me elaborate.
SecHUD: lets you see ID. MedHUD: lets you see health. Sunglasses: stops flashes. Secglasses: lets you see ID and stops flashes and used to be research. Was later changed to roundstart... for some reason.
And then there's the corpsman glasses, which let you do everything, all at once, and were merged without prior discussion. So excuse me while I comment them out until we can have a proper discussion.

The corpsman should have their box of sterilised masks.

Already addressed.

I like the noir suit. The detective should dress differently to other security officers.

See my answer in response to "I'm happy with the loadouts right now".

@TadJohnson00
Copy link
Contributor Author

As for you, Timemaster.

This is being enacted without communication and stands to offend a majority of players without need.

Unfortunately I don't have a roadmap on hand I can just drop in announcements for the community. Yet. That'll come after we get some curators in.

This shift towards a more realistic and cohesive atmosphere is one that should be announced so the public can understand why these changes are being made. If this isn't done, this PR will appear to many as off-brand for Delta.

True. And it will be done, again, when we get some curators in to work on a roadmap and something worth presenting to the community.

I understand that you'd like more communication, and that it would be helpful for the community to receive information about our plans. I've done my best to address valid concerns where I've seen them here on GitHub, and provided more concessions than I usually would expressly because of the lack of communication that you spoke of. It is something we'll be working on when we get curators, but until then these are just how the beans are cooked.

@adeinitas boots and skort a-okay.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Are we all on the same page now regarding this PR and can I merge this? I'll make the noir detective stuff accessible somehow in a seperate PR if that helps anyone, so that we will still have the option. I'll even resprite it to look better if needed.

@Alyx-Wander
Copy link

It's a nice idea, but ultimately we're not looking to start normalising any more anachronistic tropes as seen in spaghetti westerns and the like. Also, this smells like another license to validhunt.

True points indeed, and completely valid if the detective weren't a part of security - but they are, and the noir gear doesn't fit. Maybe we'll see a return of some of the noir characteristics if they're removed from security.

These arguments actually win me over to removing the Security star, and moving the noir gear from the Detective's drobe, and it also brings me to another idea. I think the hard-boiled PI look might go well with the reporter, as they're a non-security role, and I think them being an investigator could be a neat sub-class of their normal reporting roles. I've always liked the idea of having Gonzo Journalists on the station, and I think this gets kind of close.

@VileSloth
Copy link

Fine, ignore our feedback, but this PR completely neuters everything I like about security. I and many others will likely not play security on delta if this is merged, just because you feel the current state of security loadout doesn't fit the server theme, which I utterly disagree with.

When this was tried many months ago, it killed the server for me until the security changes were reverted back, and I urge you to make a public poll and discussion in announcements to see if it's truly what the players want. I hate and despise this direction delta is taking where you just seem to not give any shits about how the players feel and ignore them because "it doesn't fit deltas vision", players make up a server and if the majority of the player base doesn't like it, as it seems very clear from the comments on this PR, maybe don't fucking merge it and go back to the drawing board? The wizden armors for security are NOT overpowered, they are fine. Security is still melted in combat by nukies who can actually aim, let alone the fact security is usually wearing the delta v hardsuits on nukies, which if I recall are even better then the upstream armored vest. You wanna know how effective the wizden armored vest is? It makes a security player able to tank like two more melee swings depending, and about 2-3 more bullets of .35 ammo. The fact security would have to choose being strong against melee, or strong against guns is asinine, security should be able to respond to most threats without having to go back to security and change their armor.

I feel like this got kind of ranty, but I've made my points.
Get public opinion from discord, using the announcements chat, and explain your rationale and steps you'll take to improve security, as this just seems to make security utterly worse over all

@BlitzTheSquishy
Copy link
Contributor

Forgot to write comments. If you cant have silliness in a department in this inherently silly game. I don't think this is the game or server for you to work on.

@boogiebogus
Copy link

As someone with a good deal of security playtime, I can't agree with these changes. To me, this is removing a lot of the personality that security has at the moment, and I think trying to make security more serious and professional is absolutely not going to be a positive. Most of all, I think that trying to remove the silly elements of security that many people enjoy is going to affect both the kind of people who play security as well as how much the crew trusts security in a negative way. I'm going to have a much easier time trusting someone to be reasonable if they outwardly have a little whimsy. Additionally, from a personal perspective, I think that security should be letting things funny things slide from time to time, should it improve the round for everyone--nobody likes the fun police, and trying to make security more serious is not going to help sec players have that mentality of "I should let people have their fun sometimes".

As for the changes I can agree with:

  • Corpsman glasses do need tweaking, rather than being added as-is. I've always thought that the corpsman not being flash immune was interesting gameplay wise, because it gives them a weakness in exchange for having unrestricted access to medical supplies and equipment.
  • Replacing the corpsman survival box is good, because the corpsman breath mask sprite is honestly god-awful.
  • The armor vest always felt out of place to me, I wouldn't mind it being reintroduced with a resprite and a rename though.

@BlitzTheSquishy
Copy link
Contributor

Briefly addressed this earlier, let me elaborate. SecHUD: lets you see ID. MedHUD: lets you see health. Sunglasses: stops flashes. Secglasses: lets you see ID and stops flashes and used to be research. Was later changed to roundstart... for some reason.

heres your "for some reason"

space-wizards/space-station-14#26487

its because it was simply an inconvenience to have them split apart

@TadJohnson00
Copy link
Contributor Author

I think the hard-boiled PI look might go well with the reporter, as they're a non-security role, and I think them being an investigator could be a neat sub-class of their normal reporting roles. I've always liked the idea of having Gonzo Journalists on the station, and I think this gets kind of close.

Sure, it'd fit them better both stylistically and as part of their role. I think they used to get some detective gear in their repdrobe, but not sure.

This PR neuters everything I like about security. I and many others will likely not play security on delta if this is merged.

Welp.

If the players don't like it, maybe don't fucking merge it and go back to the drawing board.

I think perhaps you fail to understand the core reason why the role I fill exists.

I don't like having to pick between specialised body armour.

This is actually meaningful feedback that can be addressed... but probably in another PR. Raising it as a grievance here does very little, I suggest raising the issue either to direction on Discord or on the GitHub for discussion.

Get public opinion from Discord, use the announcements chat, and explain your rationale and steps to improve security

I've already received several opinions here, the majority of which were unhelpful and along the lines of "I don't like this change, don't merge it"; as for the questions and feedback, I've done my best to address them here. As I previously stated, we'll be releasing a rough roadmap when we flesh out our curator team, and we'll provide our basic rationale.

While I may be obliged to provide rationale to the general playerbase for any direction changes, there's a point at which I get tired of repeating the same points and acknowledging that people hate changes that will go through anyway. So I'm not particularly inclined to extend this any further.

If you can't have silliness in a department in this inherently silly game, I don't think this is the game or the server for you to work on.

Hey, if it's LRP you're pandering for, there's a dozen servers out there with what you want. Otherwise, I suggest you pipe down about keeping memes and silliness for its own sake, and start letting us work on building a more serious environment.

This feels like it removes a lot of the personality of Security, and I think making the department more serious and professional is not a positive change, as it will affect the kind of people that play the department.

Going to be completely honest with you, I'd take hardass over "fun" any day of the week. I've seen officers, wardens, and even heads of security act in the most rank and inappropriate manner because it was "funny". In my own experience, the more serious and professional officers are the ones least likely to: a) violate server rules, b) violate in-game policy, c) just be a generally shitty clown with security equipment.

As for the personality, I'm not exactly sure what you're communicating here, but I will say that we're not keeping things to preserve the "quirkiness" of departments - or, if we ever do, it won't be purely for that reason.

WizDen decided it was an inconvenience to have the SecHUD and sunglasses split apart.

Duly noted, that'll make it easier to revert if it comes to it.

@adeinitas sorry I keep discarding your reviews. I fixed up the comments, it's all set. For real this time.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bird just crashed into my window and I'm full of adrenaline, so here's my take on everything. (I've edited this since.)

TJ there's nothing to review. You changed nothing, you did not 'fix up the comments,' you have committed nothing since the last time I Iooked at this. Therefore, my review is the same except for what I'm going to put here as an option since you guys were talkin' of it- it is fine technically, really. I think the reporter is underappreciated and could use the clothes the det had.

I can't win if I close this due to community pressure. TJ and the directors won't like that -
and I can't win if I approve it either, because the entire community, including admins, will cannibalize me for this unpopular net removal of security content like they did last time I approved a similar PR a number of months ago. I'm tired of this. Don't call me for review, call Fox instead or some other maint, I am burnt out the discussion on this PR that is technically fine but is one that people do not like.

ghost
ghost previously approved these changes Sep 20, 2024
Signed-off-by: Tad "Taddy" Johnson <[email protected]>
ghost
ghost previously approved these changes Sep 20, 2024
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leather boot ops got on your ass.

@9rasstype
Copy link

I know this PR is basically closed and done but regarding the Noir Detective gear being anachronistic, I have a "so what?" opinion about it. There's probably a dozen costumes in the game like that. Off the top of my head I can name the Hatsune Miku outfit, Shrine Maiden outfit, gladiator armor, plague doctor outfit... I could go on. I don't really see removing these outfits as moving towards a more serious roleplay environment, to me it just removes individuality and creativity. The detective is a distinct role and deserves a unique appearance to compliment that. They are essentially the third in command of security, given that they are one of three roles to have access to lethal weapons at round start via their inspector, another anachronistic item that compliments the noir detective appearance.

@TadJohnson00
Copy link
Contributor Author

I've already briefly discussed the nature of the detective's position and unique clothing. With regards to the detective being the "third in command of security", security technically answers to neither of the specialists - corpsman or detective - but instead, the whole security department (with the notable exception of cadets, to answer to any security member) answers directly to the head of security. Every role, except for cadets, receives lethal ammunition.

As for the Inspector, there is an argument that it is an anachronistic weapon. But, that being said, a revolver is actually uniquely suited to a detective or forensic specialist's role; as a firearm feeding from an internal rotating cylinder rather than a stick magazine, it does not automatically expel spent casings as it fires and instead retains them. In other words, the revolver doesn't leave spent brass everywhere and makes it easier to analyse and clean up crimescenes. I'm personally of the opinion that the retention of the Inspector is valid.

@9rasstype
Copy link

9rasstype commented Sep 21, 2024

You've only said that the detective's existing loadout was anachronistic and "didnt fit", you didn't really comment on that there are several other outfits that are also anachronistic but we don't see any problems with them. Detective being easily recognizable isn't just for convenience, it's a gameplay mechanic for syndies, as they are one of three Security roles with lethal ammunition at round start and there used to be objectives for stealing things from the detective (engraved zippo, for example). Security Officers & Senior Officers don't start with lethal ammo, they start with a Mk18 with rubber bullets.

From personal experience, Detective is more likely to be promoted to Warden / HoS during short-staffed rounds which is why I referred to them as third in command, as well as their round start lethal ammo.

Not dropping casings at a crime scene seems like pretty thin justification for why the inspector is getting special treatment when every other security officer involved in the shootout is littering the hallways with spent casings. The inspector also still drops the casings if the user has to reload.

I understand wanting to push for a more serious or more defined roleplay environment but removing unique costumes isn't doing that, it's stripping away individuality and creativity in a video game that is supposed to be fun.

@Avalon-Proto
Copy link
Contributor

Detective being easily recognizable isn't just for convenience, it's a gameplay mechanic for syndies, as they are one of three Security roles with lethal ammunition at round start and there used to be objectives for stealing things from the detective (engraved zippo, for example). Security Officers & Senior Officers don't start with lethal ammo, they start with a Mk18 with rubber bullets.

I feel I should mention that only cadets don't get lethals now. All of sec starts off with 1 lethal mage in their rig and 1 rubber mag in the gun

@9rasstype
Copy link

I feel I should mention that only cadets don't get lethals now. All of sec starts off with 1 lethal mage in their rig and 1 rubber mag in the gun

When was that change merged?

@Avalon-Proto
Copy link
Contributor

When was that change merged?

I wanna say a week or two ago at this point

@ghost ghost merged commit 3efb0b5 into DeltaV-Station:master Sep 21, 2024
13 checks passed
@TadJohnson00 TadJohnson00 deleted the secloadouts branch September 28, 2024 10:35
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files Status: Do Not Merge Don't merge this yet Status: Needs Discussion Must be discussed Status: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.