Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Einstein Engines Cybernetic Limbs #1857

Merged
27 commits merged into from
Sep 22, 2024

Conversation

Aikakakah
Copy link
Contributor

About the PR

Imported the cybernetic limbs from EE.

Why / Balance

I'm sure there's plenty of players who would appreciate finally being able to give their characters a robotic limb!

Technical details

Adjusted species files to increase marking limits, added both variations of the EE cybernetic limbs.

Media

image

Requirements

Breaking changes

Changelog

🆑 Aikakakah

  • add: Added cybernetic limbs!

Adds cybernetic limb markings.

Signed-off-by: Aikakakah <[email protected]>
Adds the bishop limb markings.

Signed-off-by: Aikakakah <[email protected]>
Signed-off-by: Aikakakah <[email protected]>
Added Rodentia

Signed-off-by: Aikakakah <[email protected]>
Increased leg and arm markings for cybernetic markings.

Signed-off-by: Aikakakah <[email protected]>
Increased leg and arm markings for cybernetic markings.

Signed-off-by: Aikakakah <[email protected]>
Increased leg and arm markings for cybernetic markings.

Signed-off-by: Aikakakah <[email protected]>
Increased leg and arm markings for cybernetic markings.

Signed-off-by: Aikakakah <[email protected]>
Increased leg and arm markings for cybernetic markings.

Signed-off-by: Aikakakah <[email protected]>
Increased leg and arm markings for cybernetic markings.

Signed-off-by: Aikakakah <[email protected]>
Increased leg and arm markings for cybernetic markings.

Signed-off-by: Aikakakah <[email protected]>
Increased leg and arm markings for cybernetic markings.

Signed-off-by: Aikakakah <[email protected]>
Signed-off-by: Aikakakah <[email protected]>
Signed-off-by: Aikakakah <[email protected]>
Signed-off-by: Aikakakah <[email protected]>
Signed-off-by: Aikakakah <[email protected]>
Signed-off-by: Aikakakah <[email protected]>
Signed-off-by: Aikakakah <[email protected]>
Signed-off-by: Aikakakah <[email protected]>
Moving to marking folder

Signed-off-by: Aikakakah <[email protected]>
Signed-off-by: Aikakakah <[email protected]>
Signed-off-by: Aikakakah <[email protected]>
@Aikakakah Aikakakah requested review from IamVelcroboy and a team as code owners September 18, 2024 23:03
@github-actions github-actions bot added Changes: YML Changes any yml files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Status: Needs Review labels Sep 18, 2024
Copy link
Contributor

github-actions bot commented Sep 18, 2024

RSI Diff Bot; head commit 1ab6729 merging into bbdb0bd
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Einstein-Engines/Mobs/Customization/cyberlimbs/comp1/comp1_main.rsi

State Old New Status
l_arm-primary Added
l_arm-secondary Added
l_arm-tertiary Added
l_foot Added
l_hand Added
l_leg-primary Added
l_leg-secondary Added
r_arm-primary Added
r_arm-secondary Added
r_arm-tertiary Added
r_foot Added
r_hand Added
r_leg-primary Added
r_leg-secondary Added

Resources/Textures/Einstein-Engines/Mobs/Customization/cyberlimbs/comp2/comp2_main.rsi

State Old New Status
l_arm-1 Added
l_arm-2 Added
l_foot-1 Added
l_foot-2 Added
l_hand-1 Added
l_hand-2 Added
l_leg-1 Added
l_leg-2 Added
r_arm-1 Added
r_arm-2 Added
r_foot-1 Added
r_foot-2 Added
r_hand-1 Added
r_hand-2 Added
r_leg-1 Added
r_leg-2 Added

Edit: diff updated after 1ab6729

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Milon, god's strongest YML warrior 😸

Seems pretty normal as YAML, didn't catch anything wrong. I would approve, but I'm gonna pull Game Directors so they look at this because it incorporates corporations from 13 into the game via the Names ™️ and also to, if nothing else, have a third pair of eyes on it. I hate to be that fuckin' nerd but I gotta be.

@ghost ghost self-requested a review September 19, 2024 09:16
@TadJohnson00
Copy link
Contributor

Mixed on this, will get back to you shortly.

@Astrumif-y
Copy link

Definitely a must-have for delta , ive always wanted to give a character or two a robot limb after an important moment that would justify such a thing

@TadJohnson00
Copy link
Contributor

Alright, yep, I'll be fine with approving this if you remove the company names from the locale and replace it with numbers (right robotic arm 1, etc.)

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine with the generic-ization of these, now.

@ghost ghost merged commit fc8bac4 into DeltaV-Station:master Sep 22, 2024
13 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files Status: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants