Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the Frontier diagonal walls issues #1859

Closed
wants to merge 7 commits into from
Closed

Fixing the Frontier diagonal walls issues #1859

wants to merge 7 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 19, 2024 •
edited by ghost
Loading

About the PR

When I pulled Frontier's secret doors, Dvir took notice and said "Hey, we had changes, did you pull these" and pinged me in the discord!! My live reaction was "Oh fuck oh shit I missed something" and so, now, we should have:

  • smoother wall things(?)
  • Diagonal walls with proper states and better RSI cleanup

Why / Balance

Because I made an oopsie while cherrypicking / doing stuff for the artstyle. Yippee.

Technical details

YAML, Meta.jsons, some C# but it's mostly from Frontier and is up to their standard and not ours. Touches upstream files, all frontier comments. Yippee.

Media

See new-frontiers-14/frontier-station-14/pull/1603 for frontier implementation. Should do the same things in effect. If it breaks, I will cry.

Requirements

Breaking changes

Changelog

ErhardSteinhauer and others added 2 commits September 18, 2024 10:31
@ErhardSteinhauer @whatston3
@dvir001 @Cheackraze
Smooth transition for walls and windows icons (#1603)
b9e4c60 
* initial commit

* 5-state diagonal smoothing and uranium test

* fix syntax errors

* uranium walls: use 5-state diagonals

* IconSmoothing: respect target directions (WIP)

* adjust between vector angle and cardinal dir

* uranium, wood diagonal walls

* Reinforced diagonal walls

* Restore smooth tags, wood and reinf to diagonalnf

* IconSmoothSystem: comments, whitespace

* reinforced walls in diagonal_walls

* All windows: use "walls" icon smooth key

---------

Co-authored-by: Whatstone <[email protected]>
Co-authored-by: Dvir <[email protected]>
Co-authored-by: Checkraze <[email protected]>
RSI cleanup
0a58b25
@ghost ghost requested review from IamVelcroboy and a team as code owners September 19, 2024 01:43
@github-actions github-actions bot added Status: Needs Review Changes: YML Changes any yml files Changes: C# Changes any cs files Changes: Sprite Changes any png or json in an rsi labels Sep 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 19, 2024 •
edited
Loading

RSI Diff Bot; head commit 5b36acc merging into cfcab8c
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Structures/Walls/uranium_diagonal.rsi

State Old New Status
state0 Modified
state1 Modified
state2 Added
state3 Added
state4 Added

Resources/Textures/_NF/Structures/Walls/wood_diagonal.rsi

State Old New Status
state0 Modified
state1 Modified
state2 Added
state3 Added
state4 Added

Resources/Textures/_NF/Structures/Walls/reinforced_diagonal.rsi

State Old New Status
state0 Added
state1 Added
state2 Added

Edit: diff updated after 5b36acc

@TadJohnson00
Copy link
Contributor

from a direction standpoint what does this actually do

@ghost
Copy link
Author

ghost commented Sep 19, 2024 •
edited by ghost
Loading

from a direction standpoint what does this actually do

Does some funny technical shit to smooth walls and make windows / walls connect to eachother and not have seperation. To my knowledge. Also cleans up the meta.jsons.
It'll more so impact Velcro than anyone, so I'd like a few people to have eyes on this (mostly milon, deltanedas,) and others that know C# better than me because this edits it heavily as a frontier port.
IconSmoothComponent seems to be a pretty good indicator of what this does other than the meta.json cleanup.

@TadJohnson00
Copy link
Contributor

Okay, cleans up the joins or lack thereof between walls. Sounds cool to me

Repository owner closed this by deleting the head repository Sep 23, 2024
@dvir001
Copy link
Contributor

dvir001 commented Sep 23, 2024

Welp, someone should reopen this or open a new PR for this.

@MilonPL
Copy link
Contributor

MilonPL commented Sep 23, 2024

I'll pick it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IamVelcroboy IamVelcroboy Awaiting requested review from IamVelcroboy IamVelcroboy is a code owner

Assignees
No one assigned
Labels
Changes: C# Changes any cs files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TadJohnson00 @dvir001 @MilonPL @ghost @ErhardSteinhauer