Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make meteors duds on glacier #1872

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

deltanedas
Copy link
Member

About the PR

they dont explode, and if you somehow get hit by one itll just light you on fire instead of gibbing you

Why / Balance

meteors burn up in the atmosphere, it just makes sense
balance wise this literally gives engi nothing to do on survival, could have something more ice themed with station-created event schedulers

Technical details

basically its a flare

Requirements

Breaking changes

no

Changelog
🆑

  • tweak: Glacier's atmosphere now protects it from meteor storms.

@deltanedas deltanedas requested review from a team as code owners September 20, 2024 12:09
@github-actions github-actions bot added Status: Needs Review Changes: YML Changes any yml files Changes: C# Changes any cs files labels Sep 20, 2024
Copy link
Contributor

@TadJohnson00 TadJohnson00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly? Interesting idea. I'd be happy to give it a shot, it does make more sense. Before I approve for direction, have you tested this in-game and can you show us what the effects will look like using explosionui?

@deltanedas
Copy link
Member Author

it has no explosion at all

@TadJohnson00
Copy link
Contributor

Has the explosive component... threw me off

Copy link
Contributor

@MilonPL MilonPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now, test fail unrelated, should be good once someone with write perms re-runs it (coping hard)

@deltanedas deltanedas merged commit 55e6e3b into DeltaV-Station:master Sep 20, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files Status: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants