Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix chameleon projector bug #1884

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

deltanedas
Copy link
Member

About the PR

fixes #1585

Why / Balance

code so robust i think the only actual issue with it is just a mispredict

Technical details

prevent disguises being reparented
added to upstream pr too (hasnt been merged for 6 months 😭) so no comments

Media

Requirements

Breaking changes

no

Changelog
🆑

  • fix: Fixed chameleon projectors making you invisible when used with a crate.

@deltanedas deltanedas requested a review from a team as a code owner September 21, 2024 05:30
@MilonPL
Copy link
Contributor

MilonPL commented Sep 21, 2024

can't we just cherry pick and early merge the entire space-wizards/space-station-14#27111 instead of fucking with one file?

@deltanedas
Copy link
Member Author

it already was mostly

@MilonPL MilonPL merged commit 88a5080 into DeltaV-Station:master Sep 23, 2024
13 checks passed
@deltanedas deltanedas deleted the cham-proj-fix branch September 23, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invisibility bug
2 participants