Fixed pies don't drop Pie Tins after being Thrown #2048
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MilonPL
requested changes
Oct 26, 2024
| @@ -48,7 +48,7 @@ protected override void SplattedCreamPie(EntityUid uid, CreamPieComponent creamP | |||
| { | |||
| _puddle.TrySpillAt(uid, solution, out _, false); | |||
| } | |||
| if (foodComp.Trash.Count == 0) | |||
| if (foodComp.Trash.Count != 0) | |||
There was a problem hiding this comment.
Ideally should be upstreamed and then cherry-picked here, but otherwise needs a DeltaV comment.
There was a problem hiding this comment.
What's the process of cherry-picking like here? I can submit a PR on upstream, and do the cherry-picking part here.
There was a problem hiding this comment.
Make the PR upstream, then cherry pick that the commit into a new branch of your DeltaV fork and make a new PR from it labeled Early merge "(original PR title)" (#1234). Make sure to also link it somewhere in the description.
| @@ -48,7 +48,7 @@ protected override void SplattedCreamPie(EntityUid uid, CreamPieComponent creamP | |||
| { | |||
| _puddle.TrySpillAt(uid, solution, out _, false); | |||
| } | |||
| if (foodComp.Trash.Count == 0) | |||
| if (foodComp.Trash.Count != 0) | |||
There was a problem hiding this comment.
Suggested change
| if (foodComp.Trash.Count != 0) | |
| if (foodComp.Trash.Count != 0) // DeltaV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
#1843 Changed a flag check that prevent trash from being generated from pie thrown
Why / Balance
I believe it is a typo
Technical details
Checked the
Pie.ymlfile, it looks likeFoodPieBasehas the correcttrashcomponent. Consume still leaves the tin, but the splat function doesn't seem to spawn trash due to conditionfoodComp.Trash.Countbeing compared to zero.Media
None
Requirements
Breaking changes
None
Changelog