Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stock market refactor #2141

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

stock market refactor #2141

wants to merge 6 commits into from

Conversation

deltanedas
Copy link
Member

About the PR

  • renamed StockCompanyStruct to StockCompany, it didnt need Struct in its name. classes dont have Class in their name etc
  • made MarketChange a struct
  • instead of 2 copy paste functions to buy and sell, just TryChangeStocks that handles negatives to sell
  • log the user instead of loader since you can steal pdas (requires pass Actor to cartridge messages space-wizards/space-station-14#33210)

@github-actions github-actions bot added Changes: UI Changes: C# Changes any cs files labels Nov 7, 2024
@MilonPL
Copy link
Contributor

MilonPL commented Nov 7, 2024 •
edited
Loading

FUCK it only took 2 days (why didn't you stop me)

@MilonPL
Copy link
Contributor

MilonPL commented Nov 7, 2024

@deltanedas while you're at it, something that probably should've been done but I didn't think about, is also playing the deny sound if TryChangeStocks fails, to give player feedback in case we can't afford it or we don't have enough stocks to sell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Changes: C# Changes any cs files Changes: UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deltanedas @MilonPL