Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HoS's Shades #516

Closed
wants to merge 17 commits into from
Closed

HoS's Shades #516

wants to merge 17 commits into from

Conversation

ps3moira
Copy link
Contributor

@ps3moira ps3moira commented Dec 4, 2023

About the PR

Added HoS's own unique shades that has a security hud built into it.

Why / Balance

I thought it was a bit silly HoS has to swap out and carry a sec hud and sec shades.

Media

Screenshot 2023-12-03 205932

  • I have added screenshots/videos to this PR showcasing its changes ingame

Changelog
🆑

  • add: Added Head of Security's own shades.

@github-actions github-actions bot added Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files Status: Needs Review labels Dec 4, 2023
@ps3moira ps3moira mentioned this pull request Dec 4, 2023
1 task
Copy link
Contributor

github-actions bot commented Dec 4, 2023

RSI Diff Bot; head commit f65dc57 merging into bbd3e76
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Clothing/Eyes/Glasses/hossecglasses.rsi

State Old New Status
equipped-EYES-hamster Added
equipped-EYES-secdog Added
equipped-EYES Added
icon Added
inhand-left Added
inhand-right Added

Edit: diff updated after f65dc57

@Colin-Tel
Copy link
Contributor

Shouldn't this PR make the HoS/their locker spawn with these shades? Currently this just adds them to be mapped in.

@ps3moira
Copy link
Contributor Author

ps3moira commented Dec 6, 2023

Shouldn't this PR make the HoS/their locker spawn with these shades? Currently this just adds them to be mapped in.

I was going to make a separate PR for this to update a few locker's missing items.

@ps3moira
Copy link
Contributor Author

Shouldn't this PR make the HoS/their locker spawn with these shades? Currently this just adds them to be mapped in.

I decided to just add it into the locker's anyway lol. I also removed the regular sunglasses for these.

@github-actions github-actions bot added the Status: Merge Conflict Fix your PR! label Mar 8, 2024
Copy link
Contributor

github-actions bot commented Mar 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@VMSolidus
Copy link
Contributor

I'm going to close this for the same reasons as #626

@VMSolidus VMSolidus closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files Status: Merge Conflict Fix your PR! Status: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants