Implement Ifriit

[Adrian16199]

The mystagogue's guardian.

So as it stands, this can be merged upon innate tool fix gets merged into master and notin pyrokinesis until it gets reworked.
Converting it to draft and going to apply changes for it to use innate tool again.

About the PR

YML

Why / Balance

They used to be a thing, simply fixes them

Media

• I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase
  

Delta-v.2024-02-10.20-12-08.mov

Breaking changes

Changelog

🆑

• fix: Implements ifriit

[VMSolidus]

To make the ifrit spawn with a tool, you need to give them a relevant Inventory Template, so that they have handslots(Preferably ones immune to strip), and then you need a Loadout. The relevant components are

• LoadoutComponent (Define what items the Ifrit spawns with and in what slots)
• HandsComponent (They need hands to use a weapon, should be self explanatory)
• InventoryComponent (This stores a templateId, which lets you define what inventory slots the Ifrit has)
• InventorySlotsComponent (Lets the player actually see the equipment UI)

To make it so that nobody can take the tool, you just need to make sure that they don't have the StrippableComponent.

[Adrian16199]

I though about tryin to restore InnateItemSystem (which i was lookin for a bit) but I suppose trying that could be the right solution in the first place.

[VMSolidus]

I though about tryin to restore InnateItemSystem (which i was lookin for a bit) but I suppose trying that could be the right solution in the first place.

Yea, not much reason to make/remake an old component if the options to do what you want to do already exist. Wizden's already done the work for you, you just need to know what components and arguments are necessary.

[Adrian16199]

I though about tryin to restore InnateItemSystem (which i was lookin for a bit) but I suppose trying that could be the right solution in the first place.

Yea, not much reason to make/remake an old component if the options to do what you want to do already exist. Wizden's already done the work for you, you just need to know what components and arguments are necessary.

You know, I did saw the starting gear but i never saw inhand option but you reminding me, made me realize that space ninja spawns with inhand item.

[VMSolidus]

You need to remove the negative damage component here. It will cause the ifrit to directly heal people from their blunt damage if they have any.

[Adrian16199]

okay so first things first, the loadout system doesnt spawn stuff in someone's hand and even if you write that in, it spawns On you but not in your hand. Space Ninja doesnt even spawn with it in their hand but it just spawns behind them which is just stupid.

[Guess-My-Name]

You need to remove the negative damage component here. It will cause the ifrit to directly heal people from their blunt damage if they have any.

It doesn't heal people. Normal welder does 5 blunt damage when turned off, and also has litMeleeDamageBonus component, but welder has 8 extra heat damage and -5 blunt, instead of extra 10 heat like ifrit does. If you remove it, when Ifrit hand is lit, it will deal 10 heat and 5 blunt.

[github-actions]

RSI Diff Bot; head commit 83f1faf merging into f767c45
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Nyanotrasen/Objects/Tools/ifrit_hand.rsi

State	Old	New	Status
inhand-left-flame			Modified
inhand-right-flame			Modified

Edit: diff updated after 83f1faf

[Adrian16199]

Made a video showcasin that it works, made a final adjustment, merged up.
Pretty much ready.

[DebugOk]

This approval means nothing besides removing my review requirement. When @VMSolidus considers it good enough it can be merged

[DebugOk]

Inate Tools got fixed, so that can be used again

[Adrian16199]

so innate tool does indeed work but weirdly enough, only one hand appears, probably an issue on my end so will try to get it done and just push the current changes to make it less messy.

[Adrian16199]

Works ingame, changed everything neccesary and removed everything that was uneccesary due to innate tools now working, made the pyrokinesis be a note until the rework of psionics, ready for review, again.

[DebugOk]

Worst case shit horribly breaks and we revert

Stale