Felinid changes. #666
Felinid changes. #666
Conversation
A plan
github-actions
bot
added
Changes: C#
|
|
| - type: Thieving | ||
| stealthy: true | ||
| stripTimeReduction: 1 | ||
| #- type: Thieving # FUCKIN KILL. |
|
I don't like this at all, stealing has been the thing from felinids since forever and changing it up to not making sounds when they have no shoes is totally removing the goblin concept of them for a change barely nobody will ever notice. |
|
The point of removing thieving gloves is the fact that its only for antags. |
|
And besides, in the end this PR could be closed at any time if the change would be unwanted and nothing will change, felinids will still be hated for being a goblin even if they are existing, being a hardcore species that has one bonus that only applies when you are an antag. |
https://discord.com/channels/968983104247185448/968983104662409244/1195765861756190890 |
Felinids are the worst race overall and "current state" they had gloves since nyano, people don't play felinids for the stealing and removing the unique thing they have seems like a wizden change. I just don't see why you will feel bad for stealing, and definitely is not a thing that you can't do as an antag, a lot of situations can happen were the stealing thing is useful |
There are several species that are arguably worse then felinids in their current state. This is a change that gets my vouch and I'd love to see it |
|
Also pull request number 666 real |
|
felenids having thieving promotes shittery i hate it |
maybe they should have more interesting upsides other than "free antag item" |
|
666, truly the evil PR. |
for a friend to see and help
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Cos I could be at yours on friday Tonight's at the place we started It's a long way back from sorry But here I go .... How does it feel, how does it feel Just tell me something I don't know what to tell you I don't know what to say I got into my head, i'm sorry i threw it away But i'm so glad you came back, even through all the pain Let me try and mend it, i can promise that i have changed Oh, let me give you all of me Can we just sort it out for real
Signed-off-by: Adrian16199 <[email protected]>
How does it feel, how does it feel.
….yml Co-authored-by: Debug <[email protected]> Signed-off-by: Adrian16199 <[email protected]>
|
Applied the funny changes. |
| @@ -443,6 +445,14 @@ private bool IsAroundCollider(SharedPhysicsSystem broadPhaseSystem, TransformCom | |||
| sound = moverModifier.FootstepSoundCollection; | |||
| return true; | |||
| } | |||
|
|
|||
| // If soft paws and no shoes, no sound. Delta V | |||
| if (_entities.TryGetComponent(uid, out SoftPawsComponent? _) & | |||
There was a problem hiding this comment.
I would rename this component just because it could be reused for any number of other things
|
I mean, got a cool name that you could propose? |
NoShoesSilentFootsteps |
|
Fair enough. |
|
Stuff not player facing should be utilitarian and easily understood rather than cool |
|
so for some reason, the code just dies and doesnt want to work with that name. |
|
Somehow got it to work, yey. |
| { | ||
| return false; | ||
| } | ||
| // Delta V NoShoesSilentFootsteps till here. |
There was a problem hiding this comment.
I'm actually going to request that this be made using a pre-existing component. You can simply make a footstep collection for Felinids that contains only a completely silent .ogg file, and set Felinids to use this collection for their footsteps. Since it gets overridden by shoes, this would make them walk silently while barefoot without needing to touch any upstream code at all.
There was a problem hiding this comment.
could it not be changed to be optional too, a silent ogg file is 1. probably some performance landmine 2. hacky as fuck
There was a problem hiding this comment.
performance impact
Literally zero. It already plays a .ogg clientside whenever a felinid walks. It is a default component on all humanoids.
We don't need to touch upstream code at all if this can be done with a single line of yaml in a non-upstream file. Even if you consider it "Hacky", bear in mind everything we do is similarly, if not more "hacky". I consider a single-line change in a non c# file to be the most elegant solution of all.
There was a problem hiding this comment.
Literally zero. It already plays a .ogg clientside whenever a felinid walks. It is a default component on all humanoids.
It is still doing stuff every step it doesn't have to
There was a problem hiding this comment.
I've also considered that it could be done with a felinidcomponent that remcomps footstepmodifiercomponent on init.
Another potential option is tagsystem.removetag footstep , but both options I havent investigated deep enough into what would happen if either were outright removed. I happen to know that every shoe in the game temporarily modifies the species footstepmodifiercomponent, so removing it might not be safe. Whereas giving them a silent footstep sound file has a net zero performance change, and is guaranteed to work for this purpose.
|
Im just gonna copy what i wrote in the morning 10 hours into a comment because the "pending" thing is just annoying and I dont want to bother with it. The comment:
Erm, I tried this and just No. -This being an example of how it would be for a felinid to have your thing:
Delta-v.2024-02-12.12-27-22.mov-My code is basicly what stops the floor itself to stop making noise when you dont have shoes with 5 lines of code without havin to rework an entire system. -Even if, i were to make this somehow look how you suggested, at a file with a big collection of sound effects,
|
|
Ah, I actually really do appreciate that you went and made this demonstration video, which proves that I was incorrect, and that you went and did more research into the subject to figure out that the other options weren't viable. I apologize for any perceived offense, and will accept that I was incorrect. It's a good learning experience on both of our parts. I don't have perfect knowledge of these systems either, and I don't think anyone does. In light of that, and that you have done everything correctly when it comes to fully documenting changes to upstream code, I will sign this PR with my approval. |
|
yeeeeeeeeeeeeeeees no more shitters stealing |
|
Well, I wouldnt say that it was offensive, im sorry if i made it seem that way but today is not a day for me. I could make the code even shorter since I doubt that anything else or any other species would be usin this which would mean that I could just simply make it look for felinid component instead of "NoshoesSilent" component which would just make it better technicly. |
A plan that is barely functional
I just want to thank Finket, a dear friend of mine who helped me with this PR, if it wasnt for them, it probably would never work.
About the PR
Felinid's thieving gloves being gone and adding a new mechanic, soft paws.
Other tweak is making them get less speed penalty when damaged.
Why / Balance
Felinid's thieving gloves are only really one sided, there really isnt an excuse to steal from someone if you arent an antag.
Im basicly tryin to change that, whether or not someone helps.
Media
Delta-v.2024-01-16.14-57-04.mp4
Breaking changes
Changelog
🆑