Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angle Returns! #722

Closed
wants to merge 33 commits into from
Closed

Conversation

DangerRevolution
Copy link
Contributor

@DangerRevolution DangerRevolution commented Jan 27, 2024

About the PR

  • Readded Angle
  • Did a general lighting pass to cut the lights on the map
  • Did a decal, decoration and roleplay space pass (thanks to Noctrn)
  • Moved Salvage into Logistics
  • Moved Robotics to Epistemics

Why / Balance

I like Angle, Colin didn't want to do it due to the department moving required, so I remapped it.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Refer to the map render :O

Changelog
🆑 DangerRevolution

  • add: Angle returns!

@deltav-mapserver
Copy link

deltav-mapserver bot commented Jan 27, 2024

This PR contains new or changed maps:

01/28/24 16:53

@deltanedas
Copy link
Member

love when map render decides to not work when making a major map change :trollface:

@DebugOk
Copy link
Contributor

DebugOk commented Jan 27, 2024

love when map render decides to not work when making a major map change :trollface:

Because this pr is lacking a valid station prototype

Copy link
Contributor

@DebugOk DebugOk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing everything required to function as a game map, converting to draft so actions usage isn't used on this

@DebugOk DebugOk marked this pull request as draft January 27, 2024 18:37
@VMSolidus
Copy link
Contributor

You also need to touch these files for it to be a valid map:
image

image

image

@DangerRevolution
Copy link
Contributor Author

You also need to touch these files for it to be a valid map: image

image

image

waiting on velcro to help me w it on monday, plus discussing specific numbers and whatnot regarding player slots. i was new when playing on Angle so don't remember much abt the meta-aspects of it

@github-actions github-actions bot added the Changes: C# Changes any cs files label Jan 31, 2024
@DangerRevolution DangerRevolution marked this pull request as ready for review January 31, 2024 10:42
@DangerRevolution
Copy link
Contributor Author

just need to confirm with velcro which shuttle to use, forgot about that :O

@DangerRevolution
Copy link
Contributor Author

not sure what it doesn't like about Line 2

@DangerRevolution
Copy link
Contributor Author

like shoukou angle is meant to have no o2 miner, which meant that almost every angle round ended up with everyone dying of pressure and/or airloss

Will fix

@DangerRevolution DangerRevolution marked this pull request as draft February 11, 2024 12:11
@DangerRevolution DangerRevolution marked this pull request as ready for review February 15, 2024 16:00
Copy link
Contributor

@DebugOk DebugOk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File changes look fine to me, job slots and the actual map will require Velcro's approval

@DebugOk
Copy link
Contributor

DebugOk commented Mar 18, 2024

@IamVelcroboy Have these issues been resolved yet?

@DangerRevolution DangerRevolution marked this pull request as draft March 18, 2024 16:24
@DangerRevolution
Copy link
Contributor Author

it needs a minor lighting pass that i'm still making my way through

@IamVelcroboy
Copy link
Member

@IamVelcroboy Have these issues been resolved yet?

Review was done in Discord. Waiting for the changes requested there to be made.

@github-actions github-actions bot added the Status: Merge Conflict Fix your PR! label Apr 6, 2024
Copy link
Contributor

github-actions bot commented Apr 6, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: Danger Revolution! <[email protected]>
@github-actions github-actions bot removed the Status: Merge Conflict Fix your PR! label Apr 22, 2024
Signed-off-by: Danger Revolution! <[email protected]>
Signed-off-by: Danger Revolution! <[email protected]>
@deltanedas
Copy link
Member

@DangerRevolution is this real or fake

@DangerRevolution
Copy link
Contributor Author

DangerRevolution commented Jun 16, 2024

@DangerRevolution is this real or fake

It's missing Shipyard and a few misc changes, but is 99% done last I was doing it. But it realistically needs a complete lighting overhaul and probably a ground-up remake as there's literally no room for Justice or any new rooms that are needed.

I mean, I could illegally expand the station using galvanised square steel and some screws from my aunt but then the Justice Department would look wack and out of place and not Angle-y

@deltanedas
Copy link
Member

justice shittle that flies around independently :trollface: :trollface: :trollface:

@IamVelcroboy
Copy link
Member

This is the last review I did on the map. If it is confirmed that the stuff in the review has been addressed, or it is addressed in another update, I will review again from there. Discord Review

@DangerRevolution
Copy link
Contributor Author

This is the last review I did on the map. If it is confirmed that the stuff in the review has been addressed, or it is addressed in another update, I will review again from there. Discord Review

I addressed 99% of the issues you brought up in the review; not sure if it's pushed to remote.

Waiting on #721 to be merged and the follow-ups before I get back to this.

@ghost
Copy link

ghost commented Sep 18, 2024

The age old question... Security borgs has been merged; Did Danger ever get back to this? It's been such a hot minute this has been touched, and Fox picked up Angle in that time, to my knowledge

@DangerRevolution
Copy link
Contributor Author

The age old question... Security borgs has been merged; Did Danger ever get back to this? It's been such a hot minute this has been touched, and Fox picked up Angle in that time, to my knowledge

No; I haven't touched it, and have no plans to.

@TadJohnson00
Copy link
Contributor

Noted, thanks for informing us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants