-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Delta V station beacons #767
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These names do not match the original style and are way too long, additionally several are redundant.
Resources/Locale/en-US/deltav/navmap-beacons/station-beacons.ftl
Outdated
Show resolved
Hide resolved
Which ones? I could drop Glimmer Prober Room -> Glimmer Prober. I'm not sure which others don't fit though? |
Fucking all of them outside of Virology, Cloning, Park and Mailroom. Beacons for escape pods are also bloat, so is Cloning, Exam, the prober and the camera servers |
Escape pods on maps would make them easier for players to find. Epi, Logistics, Sec, Engi are all broken up into their different rooms, why would we not have one for the missing med rooms(cloning/exam) Camera servers are meant for stations that have a server room, it would be analogous to the telecoms room. Every map is encouraged to have outposts, which are analogous to Sec Checkpoints Boxing Ring, Reporter Office, Psych Office, etc are on almost every map. They will just be added manually if there isn't a pre-made beacon for them. Why wouldn't we make this simpler by just having them? |
no reason not to do it upstream |
A couple of these could probably be upstreamed, sure. Some I don't think they'd use since they don't map the same as us, or use the RP roles as much. |
escape pods specifically every map has both here and usptream |
Forgot about Mantis 😩. I'm at work now though. |
Added mantis and shortened most of the names. |
OK, made the changes. Shortened a few of the names. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very exciting, very useful, very cool to stop having to rename all the beacons.
- as in Pebble warp points are mis-named or duplicates or missing mega-thread #940 and Edge Warp Point misnamings / not-namings #942 would be very nice to avoid abbreviations that new players (the target audience for maps) and Wizdenners (the second audience for these) won't get
Resources/Prototypes/DeltaV/Entities/Objects/Devices/station_beacon.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as you aren't going to make the station maps extremely crowded, I'm fine with this
About the PR
Why / Balance
mapping goodness