Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Delta V station beacons #767

Merged
merged 9 commits into from
Mar 11, 2024
Merged

Conversation

IamVelcroboy
Copy link
Member

About the PR

  • Adds DV specific station beacons for mapping
  • Adjusts upstream beacons for DV specific changes

Why / Balance

mapping goodness

@github-actions github-actions bot added Status: Needs Review Changes: Localization Changes any ftl files Changes: YML Changes any yml files labels Feb 3, 2024
Copy link
Contributor

@DebugOk DebugOk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These names do not match the original style and are way too long, additionally several are redundant.

@IamVelcroboy
Copy link
Member Author

These names do not match the original style and are way too long

Which ones? I could drop Glimmer Prober Room -> Glimmer Prober. I'm not sure which others don't fit though?

@DebugOk
Copy link
Contributor

DebugOk commented Feb 3, 2024

These names do not match the original style and are way too long

Which ones? I could drop Glimmer Prober Room -> Glimmer Prober. I'm not sure which others don't fit though?

Fucking all of them outside of Virology, Cloning, Park and Mailroom.

Beacons for escape pods are also bloat, so is Cloning, Exam, the prober and the camera servers

@IamVelcroboy
Copy link
Member Author

Beacons for escape pods are also bloat, so is Cloning, Exam, the prober and the camera servers

Escape pods on maps would make them easier for players to find.

Epi, Logistics, Sec, Engi are all broken up into their different rooms, why would we not have one for the missing med rooms(cloning/exam)

Camera servers are meant for stations that have a server room, it would be analogous to the telecoms room.

Every map is encouraged to have outposts, which are analogous to Sec Checkpoints

Boxing Ring, Reporter Office, Psych Office, etc are on almost every map. They will just be added manually if there isn't a pre-made beacon for them. Why wouldn't we make this simpler by just having them?

@deltanedas
Copy link
Member

Escape pods on maps would make them easier for players to find.

no reason not to do it upstream

@IamVelcroboy
Copy link
Member Author

no reason not to do it upstream

A couple of these could probably be upstreamed, sure. Some I don't think they'd use since they don't map the same as us, or use the RP roles as much.

@DebugOk DebugOk added Status: Do Not Merge Don't merge this yet Status: Awaiting Changes Do not merge due to requested changes labels Feb 3, 2024
@deltanedas
Copy link
Member

escape pods specifically every map has both here and usptream

@IamVelcroboy
Copy link
Member Author

Forgot about Mantis 😩. I'm at work now though.

@IamVelcroboy
Copy link
Member Author

Added mantis and shortened most of the names.

@IamVelcroboy
Copy link
Member Author

OK, made the changes. Shortened a few of the names.

Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very exciting, very useful, very cool to stop having to rename all the beacons.

DebugOk
DebugOk previously approved these changes Mar 11, 2024
Copy link
Contributor

@DebugOk DebugOk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as you aren't going to make the station maps extremely crowded, I'm fine with this

@DebugOk DebugOk enabled auto-merge (squash) March 11, 2024 16:02
@DebugOk DebugOk merged commit fd09635 into DeltaV-Station:master Mar 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: YML Changes any yml files Status: Awaiting Changes Do not merge due to requested changes Status: Do Not Merge Don't merge this yet Status: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants