-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harpy Species #78
Harpy Species #78
Conversation
One day the linter will be happy. That day is not today
Still need to refactor ActionChangeVoiceMask into an implantable component on the DeltaV namespace
Signed-off-by: VMSolidus <[email protected]>
I'm undrafting this so I can let the Linters do their thing and validate my work. |
You can run most of the tests locally using these commands: dotnet restore
dotnet build --configuration DebugOpt --no-restore /p:WarningsAsErrors=nullable /m
dotnet run --project Content.YAMLLinter/Content.YAMLLinter.csproj --no-build -- NUnit.ConsoleOut=0
dotnet test --no-build --configuration DebugOpt Content.Tests/Content.Tests.csproj -- NUnit.ConsoleOut=0
dotnet test --no-build --configuration DebugOpt Content.IntegrationTests/Content.IntegrationTests.csproj -- NUnit.ConsoleOut=0 NUnit.MapWarningTo=Failed |
Oh I appreciate it Death! Can you mark this back as a draft then? I'll run them locally |
Signed-off-by: VMSolidus <[email protected]>
Signed-off-by: VMSolidus <[email protected]>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: VMSolidus <[email protected]>
Signed-off-by: VMSolidus <[email protected]>
RSI Diff Bot; head commit 4377106 merging into 8ad2f08 Resources/Textures/DeltaV/Mobs/Customization/Harpy/harpy_ears.rsi
Resources/Textures/DeltaV/Mobs/Customization/Harpy/harpy_tails.rsi
Resources/Textures/DeltaV/Mobs/Customization/Harpy/harpy_wings_default.rsi
|
ALRIGHT LET'S GO |
Alright great, all bugs with THIS pr are fixed, harpies are now ready to go! |
#2 |
To me, it looks good as far as the files are concerned. I'll open it up in-game and take a look at it. |
Birds will sing Signed-off-by: VMSolidus <[email protected]>
Signed-off-by: VMSolidus <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanna pat the harpy on the head.
which head? |
About the PR
This PR adds a new species to the game, that of the Harpy. Harpies are an avian humanoid species, that features colorful feathered wings+tail, and can mimick nearly any sound.
Harpies have the following mechanical traits:
(+) They have slashing based melee, in the form of their talons
(+/=) They can imitate a huge variety of noises, both organic and inorganic in nature. This includes anything from a PDA ringtone, to a pew pew laser, or even sounds that normally come from other species.
(+/=) They can natively play midis, effectively imitating entire songs.
(=) They are slightly smaller than a normal human
(-) They take %15 more airloss damage
(-) They take %15 more brute damage
Why / Balance
Harpies are made by special request to produce content uniquely intended for DeltaV. Although I don't remember who exactly, but I was told that "Monster People" races was generally wanted by the playerbase. Thus this entire PR has been a collaborative project entirely by individuals from the DeltaV discord. I promise of course that I fully intend to do Kitsune next, and I may even have an actual idea on how their fox transforming mechanic might be done with minimal new code.
Technical details
A single new YAML component has been added to the game, called type: HarpySinger. It can be added to any entity that a player might feasibly control, and allows it to use the same function PAI has for playing midis. Singer requires additional components in the form of Instrument(to declare what "Instrument" the entity is intended to use), and UserInterface to produce the necessary UI button.
Media
Credits
@JJ4321 - Coding assistance with the Singer component
@DebugOk - Coding assistance with the Singer component
@leonardo_dabepis - Spritework. All character sprites
@justanorang - Spritework, doing the UI component for singing
@DEATHB4DEFEAT - Graciously allowing me to use harpy.png from Simplestation, you're awesome!
Changelog
🆑 VMSolidus