Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harpy Species #78

Merged
merged 31 commits into from
Oct 13, 2023
Merged

Harpy Species #78

merged 31 commits into from
Oct 13, 2023

Conversation

VMSolidus
Copy link
Contributor

@VMSolidus VMSolidus commented Oct 1, 2023

About the PR

This PR adds a new species to the game, that of the Harpy. Harpies are an avian humanoid species, that features colorful feathered wings+tail, and can mimick nearly any sound.

Harpies have the following mechanical traits:
(+) They have slashing based melee, in the form of their talons
(+/=) They can imitate a huge variety of noises, both organic and inorganic in nature. This includes anything from a PDA ringtone, to a pew pew laser, or even sounds that normally come from other species.
(+/=) They can natively play midis, effectively imitating entire songs.
(=) They are slightly smaller than a normal human
(-) They take %15 more airloss damage
(-) They take %15 more brute damage

Why / Balance

Harpies are made by special request to produce content uniquely intended for DeltaV. Although I don't remember who exactly, but I was told that "Monster People" races was generally wanted by the playerbase. Thus this entire PR has been a collaborative project entirely by individuals from the DeltaV discord. I promise of course that I fully intend to do Kitsune next, and I may even have an actual idea on how their fox transforming mechanic might be done with minimal new code.

Technical details

A single new YAML component has been added to the game, called type: HarpySinger. It can be added to any entity that a player might feasibly control, and allows it to use the same function PAI has for playing midis. Singer requires additional components in the form of Instrument(to declare what "Instrument" the entity is intended to use), and UserInterface to produce the necessary UI button.

Media

birdgoespew

Credits

@JJ4321 - Coding assistance with the Singer component
@DebugOk - Coding assistance with the Singer component
@leonardo_dabepis - Spritework. All character sprites
@justanorang - Spritework, doing the UI component for singing
@DEATHB4DEFEAT - Graciously allowing me to use harpy.png from Simplestation, you're awesome!

Changelog
🆑 VMSolidus

  • add: Harpies have been added to the game as a new playable species!

@VMSolidus VMSolidus changed the title (Unfinished) (Unfinished) Harpy Species Oct 1, 2023
@DEATHB4DEFEAT DEATHB4DEFEAT marked this pull request as draft October 1, 2023 20:20
One day the linter will be happy. That day is not today
Still need to refactor ActionChangeVoiceMask into an implantable component on the DeltaV namespace
@VMSolidus
Copy link
Contributor Author

I'm undrafting this so I can let the Linters do their thing and validate my work.

@VMSolidus VMSolidus marked this pull request as ready for review October 2, 2023 22:03
@DEATHB4DEFEAT
Copy link
Member

I'm undrafting this so I can let the Linters do their thing and validate my work.

You can run most of the tests locally using these commands:

dotnet restore
dotnet build --configuration DebugOpt --no-restore /p:WarningsAsErrors=nullable /m
dotnet run --project Content.YAMLLinter/Content.YAMLLinter.csproj --no-build -- NUnit.ConsoleOut=0
dotnet test --no-build --configuration DebugOpt Content.Tests/Content.Tests.csproj -- NUnit.ConsoleOut=0
dotnet test --no-build --configuration DebugOpt Content.IntegrationTests/Content.IntegrationTests.csproj -- NUnit.ConsoleOut=0 NUnit.MapWarningTo=Failed

@VMSolidus
Copy link
Contributor Author

Oh I appreciate it Death! Can you mark this back as a draft then? I'll run them locally

@DEATHB4DEFEAT DEATHB4DEFEAT marked this pull request as draft October 2, 2023 22:11
@github-actions github-actions bot added the Status: Merge Conflict Fix your PR! label Oct 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Status: Merge Conflict Fix your PR! label Oct 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

RSI Diff Bot; head commit 4377106 merging into 8ad2f08
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Mobs/Customization/Harpy/harpy_ears.rsi

State Old New Status
harpy_ears_default Added

Resources/Textures/DeltaV/Mobs/Customization/Harpy/harpy_tails.rsi

State Old New Status
harpy_tail_swallow Added
phoenix_tail Added
rooster_tail Added

Resources/Textures/DeltaV/Mobs/Customization/Harpy/harpy_wings_default.rsi

State Old New Status
harpy Added

Edit: diff updated after 4377106

@VMSolidus VMSolidus changed the title (Unfinished) Harpy Species Harpy Species Oct 12, 2023
@VMSolidus VMSolidus marked this pull request as ready for review October 12, 2023 23:49
@VMSolidus
Copy link
Contributor Author

ALRIGHT LET'S GO

@VMSolidus
Copy link
Contributor Author

Alright great, all bugs with THIS pr are fixed, harpies are now ready to go!

@VMSolidus
Copy link
Contributor Author

#2
New Custom Species added to Rebase. That makes 3 now, with Felinids, Vulpakin, and Harpies. I'll start work in the future for Kitsune, but I don't intend to have Kitsune ready for Rebase Beta.

@Colin-Tel
Copy link
Contributor

To me, it looks good as far as the files are concerned. I'll open it up in-game and take a look at it.

Birds will sing

Signed-off-by: VMSolidus <[email protected]>
@Colin-Tel
Copy link
Contributor

image
get a load of this guy

@Colin-Tel
Copy link
Contributor

image
Thank God that's outta the way 😏

Copy link
Contributor

@Colin-Tel Colin-Tel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanna pat the harpy on the head.

@Carolyn3114
Copy link
Contributor

I wanna pat the harpy on the head.

which head?

@Colin-Tel Colin-Tel merged commit 9a9f06b into DeltaV-Station:master Oct 13, 2023
12 checks passed
DeltaV-Bot pushed a commit that referenced this pull request Oct 13, 2023
@VMSolidus VMSolidus deleted the Funny-Birbs branch November 28, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants