.38 Special mindbreaker fix + ammo techfab #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VMSolidus
reviewed
Feb 10, 2024
Resources/Prototypes/DeltaV/Entities/Objects/Weapons/Guns/Ammunition/Projectiles/special.yml
Show resolved
Hide resolved
VMSolidus
suggested changes
Feb 10, 2024
Resources/Prototypes/DeltaV/Entities/Objects/Weapons/Guns/Ammunition/Projectiles/special.yml
Show resolved
Hide resolved
VMSolidus
previously approved these changes
Feb 10, 2024
|
Having finished testing this, I believe this to be ready to merge except for one small request. Do you think you could also add the ability to manufacture generic .38 special pistol magazines in Security Techfabs? There's as a general rule of thumb an ability to make generic magazines for each gun available to the crew at those, and while it can make speedloaders for the .38 revolver, it currently doesn't have an option to make spare magazines for .38 handguns. |
I'm sure no one will use this for traitorous acts
DebugOk
approved these changes
Feb 10, 2024
DeltaV-Bot
pushed a commit
that referenced
this pull request
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Does what the PR name says.
Fix the .38 Mindbreaker not actually injecting the mindbreaker.
Add the .38 cartridge and box to the ammo techfab, lethals only since that's what wizden did with it.
Add the .38 pratice to the security techfab.
Add the "Ammo" and "Weapons" category where appropriate.
Why / Balance
Uh
Technical details
Media
Breaking changes
Changelog
🆑