Modify antagAdvantage values.

[stellar-novas]

About the PR

Reduced or removed antagAdvantage values for several roles.

Why / Balance

For several roles, antagAdvantage is too high as their job advantages either aren't actually used, or are not true advantages.

More details, originally posted on Discord, https://discord.com/channels/968983104247185448/1150555473699934370/1205366269851996250.

So, going through the list Psionic Mantis has an advantage of 5. No other epi role has an antag, the special things the mantis gets are - psi knife - 10 slash 5 holy, sure, but afaik you don't take holy if you aren't "evil" so it's only 10 slash, and you have a 30% chance to electrocute yourself on every attack if the target isn't psionic, making it useless in most pvp fights - psibreaker gun - it comes with mindbreaker rounds, which deal 3 blunt and inject mindbreaker toxin. Getting lethal rounds from sec feels about as easy as just getting a whole gun. - permission to mindbreak, and potentially slip in other drugs too? - this feels moot, since doctors also have this and they have no advantage

Cargo tech has an advantage of 2, with the comment saying it's cause externals access.
This is completely moot since techs don't have externals. Mats and autolathe (free tools) is pretty good, but it's not great and I think the full 20tc is deserved.

Salv tech has an advantage of 3, "External Access + Free hardsuit and weapons". The salvage weapons aren't ideal for pvp imo, I don't think externals is much of an advantage, I don't remember any cases of ex. a body being hidden in space, however, the weapons and similar contraband they can get definitely are. Maybe reduce to 2 advantage?

Lawyer, advantage of 2, "Security Radio and Access", having many more opportunities to steal sec stuff is pretty fair, and sec comms is very helpful.

Service worker, advantage of 1, "access", they just get service, and no other service role has an advantage, they should get 20tc. Seems to be a hold over from nyano.

Station engineer/Tech assistant, advantage of 3, "External Access + Engineering", you're trusted in a lot of higher security areas now, like substations, which imo is the main advantage, as tools are fairly easy to acquire, barring insuls and engi goggles. Maybe drop it to 2 instead?

Atmos tech, advantage of 10. "External Access + Fireaxe + Free Hardsuit", this is definetly too high, the axe's only purpose is as a weapon now, since any engineer can space floors, and the axe doesn't anymore. The only thing you gain from atmos access is maybe being able to do atmos sabotage, but that is disallowed since that generally affects large parts of the station. Your other advantages, such as being trusted some high security areas, are shared with the other engi roles. The advantage should be 2/3/4, I'm leaning towards 3.

Paramedic, advantage of 2, "External Access", I've said that I don't think it is worth the tc reduction, and whatever it is, it should definetly be lower than salv. Didn't realise they had the handheld monitor still, advantage of 1 for that.

- [x] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

• tweak: Reduced or removed TC penalty for several roles.

[github-actions]

Thank you for contributing to the Space Station 14 repository. Unfortunately, it looks like you submitted your pull request from the master branch. We suggest you follow our git usage documentation

You can move your current work from the master branch to another branch by doing git branch <branch_name and resetting the master branch.