Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psychologist & Lawyer stamp #849

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

Guess-My-Name
Copy link
Contributor

About the PR

two new stamps for better RP
added those to starting inventories as well as cmo locker (psychologist) and lawdrobe (lawyer), in case of in round promotions.

Why / Balance

currently there's no way to make a paper impossible to change without a stamp, lawyer has to ask hop for one, psychologist has to ask hop or cmo

Technical details

Media

stampShowcase3
stampShowcase2
stampShowcase1

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

  • add: Added psychologist and lawyer stamps!

@github-actions github-actions bot added Status: Needs Review Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files labels Feb 17, 2024
Copy link
Contributor

github-actions bot commented Feb 17, 2024

RSI Diff Bot; head commit e5c6c44 merging into e598e90
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Objects/Misc/stamps.rsi

State Old New Status
stamp-lawyer Added
stamp-psychologist Added

Resources/Textures/Objects/Misc/bureaucracy.rsi

State Old New Status
paper_stamp-lawyer Added
paper_stamp-psychologist Added

Edit: diff updated after e5c6c44

@dvir001
Copy link
Contributor

dvir001 commented Feb 18, 2024

You can use the frontier sprites if you want
new-frontiers-14/frontier-station-14#655
As we had the same PR not too long ago.

Copy link
Contributor

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now. If only stamps allowed setting a different RSI, so that we could avoid having to modify the upstream stamps. Eh that'll be something to PR to upstream anyway.

Copy link
Contributor

@DebugOk DebugOk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a shame this requires altering the upstream RSI, but it is what it is. It could be fixed at some point but eh

@VMSolidus VMSolidus merged commit 344aa7b into DeltaV-Station:master Mar 8, 2024
12 checks passed
DebugOk added a commit to DebugOk/Delta-v that referenced this pull request Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files Status: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants