Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Prescription huds #859

Merged
merged 8 commits into from
Mar 1, 2024
Merged

Conversation

Adrian16199
Copy link
Contributor

About the PR

WELCOME TO ANYONE WHO IS TUUUUUUUUUUNING IN.
THIS JUST IN, A WEIRD CAT HAS MADE A REVOLUTIONARY DISCOVERY AND ITS IN YOUR NEIGHBOUR HOOD!
IT WILL HELP THOSE 3 SPECIFIC PEOPLE WITH EYE PROBLEMS OR DEFFICIENCY (Not sure which one)
WITH THEEEEEEEIR STRUGGLES!!
HE HAS GLUED TOGETHER AND ADJUSTED IT WITH CABLES, A MARVELOUS PIECE OF TECHNOLOGY WITH HIS GLASSES.
PREEESENTING!
Prescription medical hud!
=w=

(For legal reasons, this advertisement was not intended to mentally or physically harm anyone nor attempt to be legally set to court due to copyright or due to resulted mass death of cats.)

Why / Balance

Yes.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase
    image

Breaking changes

Changelog

🆑

  • add: Added prescription medical hud and security hud.

THATS RIGHT.
TO THOSE 3 PLAYERS THAT USE NEARSIGHTED.
YOU CAN NOW SMASH TOGETHER A BRAND NEW TOOL TO HELP YOUR AID DURING WORKING HOURS.
*WOW, SO AMAZING.*

(For legal reasons, said advertisement was not trying to cause any mental or physical harm or legal obligations with medical and security industry who made said huds.)
@github-actions github-actions bot added Status: Needs Review Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files labels Feb 19, 2024
Copy link
Contributor

github-actions bot commented Feb 19, 2024

RSI Diff Bot; head commit 3a4579e merging into 7646796
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Clothing/Eyes/Hud/prescmedhud.rsi

State Old New Status
equipped-EYES Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Clothing/Eyes/Hud/prescsechud.rsi

State Old New Status
equipped-EYES Added
icon Added
inhand-left Added
inhand-right Added

Edit: diff updated after 3a4579e

@DangerRevolution
Copy link
Contributor

Shouldn't this be in the vendor like the eyepatches?

@Adrian16199
Copy link
Contributor Author

I mean, if the idea was to just present prescription medical hud that are properly build then I mean, I would need to make a different sprite for it and well, I just find this more funny that you would need to try really hard just to get these and its not like for some reason medical only gets medical hud eyepatches instead of normal ones but eee (shrug)
Even then, if its only intended to have 2 medical eyepatches in the vendor from wizden, addin 2 more but with just tag of prescription, would just make normal people take it incase the normal ones would be gone. At best, I would PR into upstream that medical huds would even appear in medical vendors instead of only the eyepatch one.

@DangerRevolution
Copy link
Contributor

DangerRevolution commented Feb 19, 2024

I mean, if the idea was to just present prescription medical hud that are properly build then I mean, I would need to make a different sprite for it and well, I just find this more funny that you would need to try really hard just to get these and its not like for some reason medical only gets medical hud eyepatches instead of normal ones but eee (shrug) Even then, if its only intended to have 2 medical eyepatches in the vendor from wizden, addin 2 more but with just tag of prescription, would just make normal people take it incase the normal ones would be gone. At best, I would PR into upstream that medical huds would even appear in medical vendors instead of only the eyepatch one.

Tbh thinking about it, this is probably best off upstreamed given it's QoL moreso than a unique Delta-V thing but honestly I think the sprite would pass. I honestly would've done it like park and just used the same sprite but renamed it "prescription medhud" or smth.

also the test error is fake :O

@Adrian16199
Copy link
Contributor Author

Upstream doesnt have nearsighted trait.
By upstream, I meant specficly to even allow medhuds to be even avaible thro vendors for medical and not only those eyepatches that are just weird.

@DEATHB4DEFEAT
Copy link
Member

I had only read the title and description and thought "it's funny having one eye being covered magically fix your eye issues, wonder if that's still happening" and then I saw the image and suddenly laughed seeing the mix of the two sprites, this looks great so far.

Copy link
Member

@DEATHB4DEFEAT DEATHB4DEFEAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatever IDE you use you need to get the EditorConfig extension for it, you keep leaving no newlines at the end of files

@DEATHB4DEFEAT
Copy link
Member

I honestly would've done it like park and just used the same sprite but renamed it "prescription medhud" or smth.

We don't really have anyone too good at spriting in Park (and we didn't think of mixing the two existing ones) so we just left the sprites the same thinking it was really funny to have one eye being covered magically fix the other one, we definitely should have gotten sprites for it though, glad to see Adrian has made some.

Adrian16199 and others added 2 commits February 23, 2024 22:39
Co-authored-by: DEATHB4DEFEAT <[email protected]>
Signed-off-by: Adrian16199 <[email protected]>
@VMSolidus VMSolidus merged commit a79d53c into DeltaV-Station:master Mar 1, 2024
12 checks passed
DeltaV-Bot pushed a commit that referenced this pull request Mar 1, 2024
@Adrian16199 Adrian16199 deleted the prescri-hud!! branch March 14, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files Status: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants