Makes Vulpkanin able to howl + adds some growling noises #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
github-actions
bot
added
Status: Needs Review
Changes: YML
added 5 commits
February 21, 2024 23:36
DEATHB4DEFEAT
suggested changes
Feb 23, 2024
Co-authored-by: DEATHB4DEFEAT <[email protected]> Signed-off-by: Adeinitas <[email protected]>
VMSolidus
approved these changes
Feb 24, 2024
There was a problem hiding this comment.
I appreciate that you added these to the Harpy lists as well, keeping up with that their gimmick is mimicking other species. It's a nice touch. Yea, so for the previous existing sounds, I was the one who originally added them during the Rebase project. They had old and deprecated Creative-Commons licenses, but were still valid licenses at the time I originally put them in.
DEATHB4DEFEAT
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Hooo boy. My first pull request...
Adds a howling emote so that vulpkanin can howl. Also adds some more dog growling noises to the vulpkanin growling emote, and adds all the vulp growling sounds to the Harpy growling emote, with the logic that harpies should be able to mimic it and the howls added with this PR.
Why / Balance
It's a small YAML change + I feel like Vulpkanin as a species could use more emotes / sounds. Wouldn't hurt.
Media
HowlingVulpsandHarpies.1.mp4
Changelog
🆑