Add Corspman Access & Airlocks #892
Conversation
github-actions
bot
added
Changes: Localization
|
PR should say "Fixes #891" so the issue is autoclosed on merge :) |
ok lol i dont know how literal that is so i've just added that wholecloth |
|
2 unrelated things in the same pr, no attempt at upstreaming it and they don't need a seperate access type. Medical + security is enough. |
if a doctor gets into security they can just open Corpsman locker, as it's just a medical access locker? on the other way around, a security officer with medical access can just get into their locker. I've gotten Medical access a few times as Sec, doesn't mean I should be able to just go into the Corpsman's area and rob their shit
Wizden doesn't have Mantis, nor Corpsman |
I kinda disagree. I'm always going to push for better granular access types. The current med+sec access makes for some weird mapping setups on some maps where sec has access to corpsman's stuff or med has access to corpsman's room. This would allow for better control/less wonky mapping setups. Also, as pointed out, WD does not have a brig medic/corpsman role any more. It was removed. |
|
it took a beautiful and vindicating 3 minutes for upstream to close it.
its two airlocks. |
|
I would argue with Sloth's logic but there really isn't a point |
Resources/Prototypes/DeltaV/Entities/Structures/Doors/Airlocks/access.yml
Outdated
Show resolved
Hide resolved
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: rosieposie <[email protected]>
There was a problem hiding this comment.
You also have to add the access here https://github.com/DeltaV-Station/Delta-v/blob/master/Content.Shared/Access/Components/IdCardConsoleComponent.cs#L44-L89 or no one can assign it
and here |
|
gah, i always forget somewhere |
## Mirror of PR #892: [Add Corspman Access & Airlocks](DeltaV-Station/Delta-v#892) from <img src="https://avatars.githubusercontent.com/u/131613340?v=4" alt="DeltaV-Station" width="22"/> [DeltaV-Station](https://github.com/DeltaV-Station)/[Delta-v](https://github.com/DeltaV-Station/Delta-v) <aside>PR opened by <img src="https://avatars.githubusercontent.com/u/52761126?v=4" width="16"/><a href="https://github.com/rosieposieeee"> rosieposieeee</a> at 2024-02-23 18:21:40 UTC</aside> <aside>PR merged by <img src="https://avatars.githubusercontent.com/u/52761126?v=4" width="16"/><a href="https://github.com/rosieposieeee"> rosieposieeee</a> at 2024-03-19 12:13:13 UTC</aside> <sup> `304fdcd35659c4bdcb17561d093d16b52b172b2e` </sup> --- PR changed 0 files with 0 additions and 0 deletions. The PR had the following labels: - Changes: YML - Status: Needs Review - Changes: C# - Changes: Localization --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > > <img width="524" alt="Content Client_AQ40yzRyFY" src="https://github.com/DeltaV-Station/Delta-v/assets/52761126/eb18fc39-4cba-4d4d-8ea5-25c5aedb1e34"> > > > """Corpsman""" access previously was just medical access on their locker (lol!) and NO access on their suit locker (LOL) > > Tested and works. HoS was given the access too. Warden left out. > > **Changelog** > 🆑 > - add: Added Corpsman-only access and airlocks. > </details> Co-authored-by: rosieposie <[email protected]>
About the PR
"""Corpsman""" access previously was just medical access on their locker (lol!) and NO access on their suit locker (LOL)
Tested and works. HoS was given the access too. Warden left out.
Changelog
🆑