Port frontier station 14's sizeattribute system

Content.Server/Cloning/CloningSystem.cs

@@ -1,3 +1,4 @@
+using Content.Server._NF.Cloning;
 using Content.Server.Atmos.EntitySystems;
 using Content.Server.Chat.Systems;
 using Content.Server.Cloning.Components;
@@ -49,6 +50,8 @@
 using Content.Shared.SSDIndicator;
 using Content.Shared.Damage.ForceSay;
 using Content.Server.Polymorph.Components;
+using Content.Server._NF.Cloning; //Frontier - needed for implementation of ITransferredByCloning
+using Robust.Shared.Serialization.Manager; // Frontier
 
 namespace Content.Server.Cloning
 {
@@ -78,6 +81,7 @@ public sealed class CloningSystem : EntitySystem
         [Dependency] private readonly SharedJobSystem _jobs = default!;
         [Dependency] private readonly MetempsychoticMachineSystem _metem = default!; //DeltaV
         [Dependency] private readonly TagSystem _tag = default!; //DeltaV
+        [Dependency] private readonly ISerializationManager _serialization = default!; //Frontier -> deltav
 
         public readonly Dictionary<MindComponent, EntityUid> ClonesWaitingForMind = new();
         public const float EasyModeCloningCost = 0.7f;
@@ -248,11 +252,22 @@ public bool TryCloning(EntityUid uid, EntityUid bodyToClone, Entity<MindComponen
             }
             // end of genetic damage checks
 
-            var mob = FetchAndSpawnMob(clonePod, pref, speciesPrototype, humanoid, bodyToClone, karmaBonus); //DeltaV Replaces CloneAppearance with Metem/Clone via FetchAndSpawnMob 
+            var mob = FetchAndSpawnMob(clonePod, pref, speciesPrototype, humanoid, bodyToClone, karmaBonus); //DeltaV Replaces CloneAppearance with Metem/Clone via FetchAndSpawnMob
 
             ///Nyano - Summary: adds the potential psionic trait to the reanimated mob.
             EnsureComp<PotentialPsionicComponent>(mob);
 
+            // Frontier - transfer of special components, e.g. small/big traits
+            foreach (var comp in EntityManager.GetComponents(bodyToClone))
+            {
+                if (comp is ITransferredByCloning)
+                {
+                    var copy = _serialization.CreateCopy(comp, notNullableOverride: true);
+                    copy.Owner = mob;
+                    EntityManager.AddComponent(mob, copy, overwrite: true);
+                }
+            }
+
             var ev = new CloningEvent(bodyToClone, mob);
             RaiseLocalEvent(bodyToClone, ref ev);
 

Content.Server/_NF/Cloning/ITransferredByCloning.cs

@@ -0,0 +1,8 @@
+namespace Content.Server._NF.Cloning;
+
+/// <summary>
+///   Indicates that this Component should be transferred to the new entity when the entity is cloned (for example, using a cloner)
+/// </summary>
+public interface ITransferredByCloning
+{
+}

Content.Server/_NF/SizeAttribute/SizeAttributeComponent.cs

@@ -0,0 +1,14 @@
+using Content.Server._NF.Cloning;
+
+namespace Content.Server._NF.SizeAttribute
+{
+    [RegisterComponent]
+    public sealed partial class SizeAttributeComponent : Component, ITransferredByCloning
+    {
+        [DataField("short")]
+        public bool Short = false;
+
+        [DataField("tall")]
+        public bool Tall = false;
+    }
+}

Content.Server/_NF/SizeAttribute/SizeAttributeSystem.cs

@@ -0,0 +1,95 @@
+using System.Numerics;
+using Content.Server.SizeAttribute;
+using Robust.Server.GameObjects;
+using Robust.Shared.Physics;
+using Robust.Shared.Physics.Collision.Shapes;
+using Robust.Shared.Physics.Systems;
+using Content.Shared.Item.PseudoItem;
+using Content.Shared.Nyanotrasen.Item.PseudoItem;
+
+namespace Content.Server._NF.SizeAttribute
+{
+    public sealed class SizeAttributeSystem : EntitySystem
+    {
+        [Dependency] private readonly IEntityManager _entityManager = default!;
+        [Dependency] private readonly SharedPhysicsSystem _physics = default!;
+        [Dependency] private readonly AppearanceSystem _appearance = default!;
+        [Dependency] private readonly FixtureSystem _fixtures = default!;
+        public override void Initialize()
+        {
+            base.Initialize();
+            SubscribeLocalEvent<SizeAttributeComponent, ComponentInit>(OnComponentInit);
+        }
+
+        private void OnComponentInit(EntityUid uid, SizeAttributeComponent component, ComponentInit args)
+        {
+            if (!TryComp<SizeAttributeWhitelistComponent>(uid, out var whitelist))
+                return;
+
+            if (whitelist.Tall && component.Tall)
+            {
+                Scale(uid, component, whitelist.TallScale, whitelist.TallDensity, whitelist.TallCosmeticOnly);
+                PseudoItem(uid, component, whitelist.TallPseudoItem);
+            }
+            else if (whitelist.Short && component.Short)
+            {
+                Scale(uid, component, whitelist.ShortScale, whitelist.ShortDensity, whitelist.ShortCosmeticOnly);
+                // deltav: added PseudoItemShape
+                PseudoItem(uid, component, whitelist.ShortPseudoItem, whitelist.PseudoItemShape);
+            }
+        }
+
+        // deltav: added a shape argument and refactored the method
+        private void PseudoItem(EntityUid uid, SizeAttributeComponent component, bool active, List<Box2i>? shape = null)
+        {
+            if (active)
+            {
+                var pseudoItem = EnsureComp<PseudoItemComponent>(uid);
+                pseudoItem.Shape = shape;
+            }
+            else
+            {
+                if (!TryComp<PseudoItemComponent>(uid, out var pseudoI))
+                    return;
+                RemComp(uid, pseudoI);
+            }
+        }
+
+        private void Scale(EntityUid uid, SizeAttributeComponent component, float scale, float density, bool cosmeticOnly)
+        {
+            if (scale <= 0f && density <= 0f)
+                return;
+
+            _entityManager.EnsureComponent<ScaleVisualsComponent>(uid);
+
+            var appearanceComponent = _entityManager.EnsureComponent<AppearanceComponent>(uid);
+            if (!_appearance.TryGetData<Vector2>(uid, ScaleVisuals.Scale, out var oldScale, appearanceComponent))
+                oldScale = Vector2.One;
+
+            _appearance.SetData(uid, ScaleVisuals.Scale, oldScale * scale, appearanceComponent);
+
+            if (!cosmeticOnly && _entityManager.TryGetComponent(uid, out FixturesComponent? manager))
+            {
+                foreach (var (id, fixture) in manager.Fixtures)
+                {
+                    if (!fixture.Hard || fixture.Density <= 1f)
+                        continue; // This will skip the flammable fixture and any other fixture that is not supposed to contribute to mass
+
+                    switch (fixture.Shape)
+                    {
+                        case PhysShapeCircle circle:
+                            _physics.SetPositionRadius(uid, id, fixture, circle, circle.Position * scale, circle.Radius * scale, manager);
+                            break;
+                        default:
+                            throw new NotImplementedException();
+                    }
+
+                    _physics.SetDensity(uid, id, fixture, density);
+                }
+            }
+        }
+    }
+
+    [ByRefEvent]
+    public readonly record struct ScaleEntityEvent(EntityUid Uid) { }
+}

Content.Server/_NF/SizeAttribute/SizeAttributeWhitelistComponent.cs

@@ -0,0 +1,48 @@
+using Robust.Shared.Physics.Collision.Shapes;
+
+namespace Content.Server.SizeAttribute
+{
+    [RegisterComponent]
+    public sealed partial class SizeAttributeWhitelistComponent : Component
+    {
+        // Short
+        [DataField("short")]
+        public bool Short = false;
+
+        [DataField("shortscale")]
+        public float ShortScale = 0f;
+
+        [DataField("shortDensity")]
+        public float ShortDensity = 0f;
+
+        [DataField("shortPseudoItem")]
+        public bool ShortPseudoItem = false;
+
+        [DataField("shortCosmeticOnly")]
+        public bool ShortCosmeticOnly = true;
+
+        // Delta-v: added custom pseudo-item shape
+        /// <summary>
+        /// An optional override for the shape of the item within the grid storage.
+        /// If null, a default shape will be used based on <see cref="Size"/>.
+        /// </summary>
+        [DataField("pseudoItemShape")]
+        public List<Box2i>? PseudoItemShape;
+
+        // Tall
+        [DataField("tall")]
+        public bool Tall = false;
+
+        [DataField("tallscale")]
+        public float TallScale = 0f;
+
+        [DataField("tallDensity")]
+        public float TallDensity = 0f;
+
+        [DataField("tallPseudoItem")]
+        public bool TallPseudoItem = false;
+
+        [DataField("tallCosmeticOnly")]
+        public bool TallCosmeticOnly = true;
+    }
+}

Resources/Prototypes/DeltaV/Entities/Mobs/Species/vulpkanin.yml

@@ -97,6 +97,16 @@
       Female: FemaleVulpkanin
       Unsexed: MaleVulpkanin
   - type: DogVision
+  - type: SizeAttributeWhitelist # Frontier - tall/short traits
+    short: true
+    shortscale: 0.8
+    shortDensity: 140
+    shortPseudoItem: true
+    shortCosmeticOnly: false
+    pseudoItemShape: # Delta-v - custom pseudo-item shape
+    - 0,0,1,4
+    - 0,2,3,4
+    - 4,0,5,4
 
 - type: entity
   save: false

Resources/Prototypes/Entities/Mobs/Species/reptilian.yml

@@ -59,6 +59,9 @@
       types:
         Heat : 1.5 #per second, scales with temperature & other constants
   - type: Wagging
+  - type: SizeAttributeWhitelist # Frontier - tall/short traits (cosmetic-only)
+    tall: true
+    tallscale: 1.2
 
 - type: entity
   parent: BaseSpeciesDummy

Resources/Prototypes/Nyanotrasen/Entities/Mobs/Species/felinid.yml

@@ -64,6 +64,9 @@
       Unsexed: MaleFelinid
   - type: Felinid
   - type: NoShoesSilentFootsteps
+  - type: SizeAttributeWhitelist # Frontier - tall/short traits (cosmetic-only, but does remove pseudo-item)
+    tall: true
+    tallscale: 1
 
 - type: entity
   save: false

Resources/Prototypes/_NF/Traits/sizeattribute.yml

@@ -0,0 +1,25 @@
+- type: trait
+  id: Tall
+  name: Tall
+  whitelist:
+    components:
+    - SizeAttributeWhitelist
+  blacklist:
+    components:
+    - SizeAttribute
+  components:
+  - type: SizeAttribute
+    tall: true
+
+- type: trait
+  id: Short
+  name: Short
+  whitelist:
+    components:
+    - SizeAttributeWhitelist
+  blacklist:
+    components:
+    - SizeAttribute
+  components:
+  - type: SizeAttribute
+    short: true