Skip to content

Commit

Permalink
remove strategy matrix temporarily
Browse files Browse the repository at this point in the history
  • Loading branch information
ahmad-el-sayed committed Feb 7, 2024
1 parent b711197 commit 78b8e1d
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 17 deletions.
31 changes: 19 additions & 12 deletions .github/workflows/build-and-test-feature.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,24 @@ jobs:

build:

strategy:
fail-fast: false
matrix:
target_platform:
- 'ubuntu-latest'
- 'macos-latest'
build_type:
- 'Release'
- 'Debug'

uses: ./.github/workflows/build-and-test-workflow.yml
with:
target_platform: ${{ matrix.target_platform }}
build_type: ${{ matrix.build_type }}
platform: ubuntu-latest
build_type: Release

# build:

# strategy:
# fail-fast: false
# matrix:
# platform:
# - ubuntu-latest
# - macos-latest
# build_type:
# - Release
# - Debug

# uses: ./.github/workflows/build-and-test-workflow.yml
# with:
# platform: ${{ matrix.platform }}
# build_type: ${{ matrix.build_type }}
10 changes: 5 additions & 5 deletions .github/workflows/build-and-test-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ name: Build and test workflow
on:
workflow_call:
inputs:
target_platform:
description: "Target platform"
platform:
description: "Platform"
required: true
type: string
build_type:
Expand All @@ -17,9 +17,9 @@ jobs:
build:

# Build platform
runs-on: ${{ inputs.target_platform }}
runs-on: ${{ inputs.platform }}

name: ${{ inputs.target_platform }}-${{ inputs.build_type }}
name: ${{ inputs.platform }}-${{ inputs.build_type }}

# The default compiler on macos is clang, switch to gcc 11. Specifying the version is necessary.
# It seems like gcc and g++ are symbolic links to the default clang and clang++ compilers, respectively.
Expand Down Expand Up @@ -116,6 +116,6 @@ jobs:
uses: actions/upload-artifact@v4
if: always()
with:
name: meshkernel-${{ inputs.target_platform }}-${{ inputs.build_type }}
name: meshkernel-${{ inputs.platform }}-${{ inputs.build_type }}
path: ${{ steps.paths.outputs.install_dir }}
if-no-files-found: error

0 comments on commit 78b8e1d

Please sign in to comment.