GRIDEDIT-758 Added mesh transformation. #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacarniato
approved these changes
Nov 10, 2023
|
|
||
| private: | ||
| /// @brief The rotation part of the transformation | ||
| Rotation rotation_; |
There was a problem hiding this comment.
for consistency we should use m_rotation, although i like rotation_ more for alphabetical sorting
…://github.com/Deltares/MeshKernel into feature/GRIDEDIT-758_transform_cartesian_grid
…tion Also, all angles for the rotation have been changed to degrees.
lucacarniato
deleted the
feature/GRIDEDIT-758_transform_cartesian_grid
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.