-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/gridedit 1336 avoid double computations #378
Merged
BillSenior
merged 17 commits into
master
from
feature/GRIDEDIT-1336_avoid_double_computations
Oct 31, 2024
Merged
Feature/gridedit 1336 avoid double computations #378
BillSenior
merged 17 commits into
master
from
feature/GRIDEDIT-1336_avoid_double_computations
Oct 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillSenior
force-pushed
the
feature/GRIDEDIT-1336_avoid_double_computations
branch
4 times, most recently
from
October 21, 2024 15:22
1a0d30f
to
3ed22e2
Compare
BillSenior
force-pushed
the
feature/GRIDEDIT-1336_avoid_double_computations
branch
from
October 30, 2024 10:07
3ed22e2
to
2b8b210
Compare
lucacarniato
requested changes
Oct 30, 2024
libs/MeshKernelApi/include/MeshKernelApi/BoundariesAsPolygonCache.hpp
Outdated
Show resolved
Hide resolved
Added comment indicating that a caching function must be called before getting the results of the cache Moved some api tests to a separate file.
lucacarniato
approved these changes
Oct 31, 2024
BillSenior
deleted the
feature/GRIDEDIT-1336_avoid_double_computations
branch
October 31, 2024 13:50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.