Feature/gridedit 1548 casulli refinement depths #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillSenior
force-pushed
the
feature/GRIDEDIT-1548_casulli_refinement_depths
branch
from
52fde8f to
c38c831
Compare
BillSenior
commented
Dec 19, 2024
Comment on lines
+47
to
+92
|
|
||
| double searchRadiusSquared = 1.0e5; | ||
|
|
There was a problem hiding this comment.
Where did this number (1e5) come from?
BillSenior
commented
Dec 19, 2024
BillSenior
commented
Dec 19, 2024
BillSenior
commented
Dec 19, 2024
Comment on lines
+139
to
+153
| std::map<int, std::unique_ptr<PropertyCalculator>> allocatePropertyCalculators() | ||
| { | ||
| std::map<int, std::unique_ptr<PropertyCalculator>> propertyMap; | ||
|
|
||
| int propertyId = static_cast<int>(meshkernel::Mesh2D::Property::Orthogonality); | ||
| propertyMap.emplace(propertyId, std::make_unique<OrthogonalityPropertyCalculator>()); | ||
|
|
||
| propertyId = static_cast<int>(meshkernel::Mesh2D::Property::EdgeLength); | ||
| propertyMap.emplace(propertyId, std::make_unique<EdgeLengthPropertyCalculator>()); | ||
|
|
||
| return propertyMap; | ||
| } | ||
|
|
||
| /// @brief Map of property calculators, from an property identifier to the calculator. | ||
| static std::map<int, std::unique_ptr<PropertyCalculator>> propertyCalculators = allocatePropertyCalculators(); |
There was a problem hiding this comment.
Could this be implemented as a singlton rather than a static global variable
BillSenior
commented
Dec 19, 2024
libs/MeshKernel/include/MeshKernel/SampleTriangulationInterpolator.hpp
Outdated
Show resolved
Hide resolved
BillSenior
commented
Dec 19, 2024
BillSenior
commented
Dec 19, 2024
BillSenior
commented
Dec 19, 2024
lucacarniato
approved these changes
Dec 19, 2024
|
|
||
| /// @brief A simple bounded array | ||
| template <const UInt Dimension> | ||
| class BoundedArray |
There was a problem hiding this comment.
if the dimension in known at compile time, can we use an std::array ?
| { | ||
| m_elementCentreRTree->SearchNearestPoint(pnt); | ||
|
|
||
| if (m_elementCentreRTree->HasQueryResults()) |
There was a problem hiding this comment.
consider early returning instead
BillSenior
commented
Dec 19, 2024
Added api unit functions and unit test, though the test does not yet work correctly
Added missing file and updated cmake file
…tree in that interpolator
…e centres for triangulation interpolation
and simple unit test
BillSenior
force-pushed
the
feature/GRIDEDIT-1548_casulli_refinement_depths
branch
from
018ba63 to
16ab4cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.