Fix dommel basin areas #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Martijn Visser <[email protected]>
…sim-NL into fix_dommel_network
visr
reviewed
Aug 20, 2024
visr
approved these changes
Aug 20, 2024
Co-authored-by: Martijn Visser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All code to fix: #132
Some properties/methods in ribasim_nl.Model:
unassigned_basin_area: basin area not assigned to a valid basin node_idbasin_node_without_area: basins without an areafix_unassigned_basin_area(): Assign a Basin node_id to a Basin / Area if the Area doesn't contain a basin node_idResults in model 2024.8.2: https://deltares.thegood.cloud/f/118021