Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functies voor werken met GKW data #233

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Functies voor werken met GKW data #233

merged 3 commits into from
Jan 20, 2025

Conversation

DanielTollenaar
Copy link
Collaborator

Voor werken met landelijke dataset: https://service.pdok.nl/hwh/kunstwerkenimwa/atom/waterschappen_kunstwerken_imwa.xml

df = get_data_from_gkw(layers= ["gemaal", "stuw", "sluis"], authority = "Noorderzijlvest") geeft je 1 DataFrame gefilterd voor layers en authority. Voor nu gebruiken we deze alleen om de naam uit te lezen.

Graag even testen of bovenstaande regel werkt en de laatste data van de CloudStorage haalt. len(df) moet 418 records zijn.

@DanielTollenaar DanielTollenaar requested a review from visr January 17, 2025 15:18
@DanielTollenaar DanielTollenaar changed the title Functies foor werken met GKW data Functies voor werken met GKW data Jan 17, 2025
@visr
Copy link
Member

visr commented Jan 20, 2025

I get FileNotFoundError: file for layer gemaal does not exist d:\set\nl\Basisgegevens\GKW\zandvang.gpkg\gemaal.gpkg

zandvang.gpkg\gemaal.gpkg doesn't seem right. I do have d:\set\nl\Basisgegevens\GKW\gemaal.gpkg locally.

@DanielTollenaar
Copy link
Collaborator Author

DanielTollenaar commented Jan 20, 2025

I get FileNotFoundError: file for layer gemaal does not exist d:\set\nl\Basisgegevens\GKW\zandvang.gpkg\gemaal.gpkg

zandvang.gpkg\gemaal.gpkg doesn't seem right. I do have d:\set\nl\Basisgegevens\GKW\gemaal.gpkg locally.

This I can't reproduce. I've:

  1. removed the path to latest GKW, in my case d:\projecten\D2306.LHM_RIBASIM\02.brongegevens\Basisgegevens\GKW\20250117
  2. ran:
from ribasim_nl.gkw import get_data_from_gkw
df = get_data_from_gkw(layers= ["gemaal", "stuw", "sluis"], authority = "Noorderzijlvest")

Result:
image

Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. After clearing my local folder it works for me as well. It probably just cannot handle the old data location without the 20250117 subdir.

@visr visr merged commit c265e24 into main Jan 20, 2025
4 checks passed
@visr visr deleted the GKW-API branch January 20, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants