Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat UserDemand return flow as a source #1226

Merged
merged 14 commits into from
Mar 21, 2024
Merged

Conversation

SouthEndMusic
Copy link
Collaborator

Fixes #1212.

@SouthEndMusic SouthEndMusic marked this pull request as draft March 11, 2024 13:30
@SouthEndMusic
Copy link
Collaborator Author

This PR is blocked by #1188 because the test model introduced in this PR is nice for testing the functionality introduced in this PR.

@SouthEndMusic SouthEndMusic changed the title Remove obsolete functions Treat UserDemand return flow as a source Mar 11, 2024
@SouthEndMusic SouthEndMusic marked this pull request as ready for review March 20, 2024 13:43
If not explicitly avoided, UserDemands can use their own return flow in this allocation problem formulation.
Therefore, return flow of UserDemand is only taken into account by allocation if that return flow is downstream of the UserDemand where it comes from. That is, if there is no path in the directed allocation network from the UserDemand outflow node back to the UserDemand.

# Solving the allocation problem {#sec-solving-allocation}
Copy link
Collaborator Author

@SouthEndMusic SouthEndMusic Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the Solving the allocation problem section as it is tedious to maintain and probably doesn't help anyone.

@Jingru923 Jingru923 self-requested a review March 20, 2024 14:59
@SouthEndMusic SouthEndMusic merged commit 040afee into main Mar 21, 2024
24 checks passed
@SouthEndMusic SouthEndMusic deleted the UserDemand_outflow_source branch March 21, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UserDemand outflow source
3 participants