Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable read method again with the new add API #1243

Merged
merged 6 commits into from
Mar 13, 2024
Merged

Enable read method again with the new add API #1243

merged 6 commits into from
Mar 13, 2024

Conversation

evetion
Copy link
Member

@evetion evetion commented Mar 13, 2024

Re-introduce database context (originally in removed Network node) and split Node tables per Node. Fixes #1232

@evetion evetion requested a review from Hofer-Julian March 13, 2024 10:34
Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please enable all tests with reason "Needs Model read implementation"?

python/ribasim/tests/test_model.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After mypy is happy, this is ready to go from my side.
Thanks!

@evetion evetion changed the title Re-introduce database context and split Node tables per Node. Enable read method again with the new add API Mar 13, 2024
@evetion evetion merged commit e1f8b81 into main Mar 13, 2024
24 checks passed
@evetion evetion deleted the fix/read-model branch March 13, 2024 13:10
@visr visr mentioned this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Model.read again to Ribasim Python
2 participants