Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PID example #1373

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Fix PID example #1373

merged 1 commit into from
Apr 11, 2024

Conversation

SouthEndMusic
Copy link
Collaborator

Fixes #1372.

There were some mistakes in the schematization.

@SouthEndMusic SouthEndMusic requested a review from Jingru923 April 10, 2024 16:57
Jingru923
Jingru923 approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@Jingru923 Jingru923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran it locally and was successful. Code looks good to me.

@visr visr merged commit 51bc8ae into main Apr 11, 2024
24 checks passed
@visr visr deleted the fix_pid_example branch April 11, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jingru923 Jingru923 Jingru923 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PID control example plot is broken
3 participants
@SouthEndMusic @Jingru923 @visr