Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document teamcity pipeline #1387

Merged
merged 6 commits into from
Apr 16, 2024
Merged

Document teamcity pipeline #1387

merged 6 commits into from
Apr 16, 2024

Conversation

Jingru923
Copy link
Contributor

Fixes #1331

@Jingru923 Jingru923 linked an issue Apr 15, 2024 that may be closed by this pull request
Document TeamCity pipeline #1331
Closed
@Jingru923 Jingru923 requested a review from evetion April 15, 2024 12:39
Hofer-Julian
Hofer-Julian suggested changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a quick look and suggested a few things.

One thing that would make reviewing easier is if you would make a newline after every sentence. This doesn't change the produced output, but makes it easier to comment.

docs/contribute/ci.qmd Outdated Show resolved Hide resolved
docs/contribute/ci.qmd Outdated Show resolved Hide resolved
docs/contribute/ci.qmd Outdated Show resolved Hide resolved
docs/contribute/ci.qmd Outdated Show resolved Hide resolved
docs/contribute/ci.qmd Outdated Show resolved Hide resolved
docs/contribute/ci.qmd Outdated Show resolved Hide resolved
docs/contribute/ci.qmd Outdated Show resolved Hide resolved
docs/contribute/ci.qmd Outdated Show resolved Hide resolved
docs/contribute/ci.qmd Outdated Show resolved Hide resolved
docs/contribute/ci.qmd Outdated Show resolved Hide resolved
@evetion
Copy link
Member

evetion commented Apr 16, 2024

I've got a few more changes, just hold off merging please :)

@Jingru923 Jingru923 merged commit 9b76c45 into main Apr 16, 2024
24 checks passed
@Jingru923 Jingru923 deleted the document-teamcity-pipeline branch April 16, 2024 14:32
@evetion
Copy link
Member

evetion commented Apr 16, 2024

Nvm 😓

@Jingru923
Copy link
Contributor Author

@evetion I clicked merge like 5 seconds before seeing your comments. Can you put your comments here and I will do a follow-up PR?

@Hofer-Julian Hofer-Julian mentioned this pull request Apr 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hofer-Julian Hofer-Julian Hofer-Julian approved these changes

@evetion evetion Awaiting requested review from evetion

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document TeamCity pipeline
3 participants
@Jingru923 @evetion @Hofer-Julian