Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the same network for allocation as for the physical layer #1399

Merged
merged 16 commits into from
Apr 22, 2024
Merged

Use the same network for allocation as for the physical layer #1399

merged 16 commits into from
Apr 22, 2024

Conversation

SouthEndMusic
Copy link
Collaborator

@SouthEndMusic SouthEndMusic commented Apr 17, 2024 •
edited
Loading

Fixes #1388.

This also fixes a bug I found: In allocation the max_flow_rate of a node connecting the main network to a subnetwork was not taken into account

@SouthEndMusic SouthEndMusic marked this pull request as draft April 17, 2024 07:02
@visr visr mentioned this pull request Apr 18, 2024
Closed
@SouthEndMusic SouthEndMusic marked this pull request as ready for review April 18, 2024 13:51
@SouthEndMusic SouthEndMusic requested a review from visr April 18, 2024 13:52
visr
visr approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a nice simplification!

docs/core/allocation.qmd Outdated Show resolved Hide resolved
docs/core/allocation.qmd Outdated Show resolved Hide resolved
docs/core/allocation.qmd Outdated Show resolved Hide resolved
docs/core/allocation.qmd Outdated Show resolved Hide resolved
core/src/util.jl Outdated Show resolved Hide resolved
core/src/parameter.jl Outdated Show resolved Hide resolved
core/src/allocation_optim.jl Show resolved Hide resolved
core/src/allocation_init.jl Outdated Show resolved Hide resolved
core/src/allocation_init.jl Outdated Show resolved Hide resolved
core/src/allocation_init.jl Outdated Show resolved Hide resolved
@SouthEndMusic SouthEndMusic merged commit e3bf329 into main Apr 22, 2024
24 checks passed
@SouthEndMusic SouthEndMusic deleted the 1_to_1_allocation_networks branch April 22, 2024 14:24
@visr visr mentioned this pull request Apr 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visr visr visr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use same network for allocation and flow
2 participants
@SouthEndMusic @visr