bump version and...

add comments about forcing (time), change @show to log info

Project.toml

@@ -1,7 +1,7 @@
 name = "Wflow"
 uuid = "d48b7d99-76e7-47ae-b1d5-ff0c1cf9a818"
 authors = ["Deltares and contributors"]
-version = "0.5.2"
+version = "0.6.0"
 
 [deps]
 BasicModelInterface = "59605e27-edc0-445a-b93d-c09a3a50b330"

docs/src/changelog.md

@@ -5,7 +5,7 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## Unreleased
+## v0.6.0 - 2022-04-14 
 
 ### Added
 - The [FLEXTopo](@ref config_flextopo) model.

src/flextopo_model.jl

@@ -23,7 +23,7 @@ function initialize_flextopo_model(config::Config)
 
     classes = get(config.model, "classes", "")
     nclass = length(classes)
-    @show classes nclass
+    @info "Classes are set to names `$(join(classes,", "))` and have size `$nclass`."
     kclass = [1]    #needed to initialize
 
     # dictionary of available functions for each store

src/io.jl

@@ -162,7 +162,7 @@ function get_at(
     times::AbstractVector{<:TimeType},
     t::TimeType,
 )
-    # this behaves like a forward fill interpolation
+    # this behaves like a backward fill interpolation
     i = findfirst(>=(t), times)
     t < first(times) && throw(DomainError("time $t before dataset begin $(first(times))"))
     i === nothing && throw(DomainError("time $t after dataset end $(last(times))"))
@@ -253,6 +253,10 @@ function update_forcing!(model)
         param_lake = get_param_lake(model)
     end
 
+    # Wflow expects `right` labeling of the forcing time interval, e.g. daily precipitation
+    # at 01-02-2000 00:00:00 is the accumulated total precipitation between 01-01-2000
+    # 00:00:00 and 01-02-2000 00:00:00.
+
     # load from NetCDF into the model according to the mapping
     for (par, ncvar) in forcing_parameters
         # no need to update fixed values