return empty dataframe instead of none

Deltares · Mar 12, 2024 · 8620545 · 8620545
1 parent 74cc608
commit 8620545
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/ddlpy/ddlpy.py b/ddlpy/ddlpy.py
@@ -330,9 +330,9 @@ def measurements(location, start_date, end_date, clean_df=True):
             continue
 
     if len(measurements) == 0:
-        # early return in case of no data
+        # return empty dataframe in case of no data
         logger.debug("no data found for this station and time extent")
-        return
+        return pd.DataFrame()
 
     measurements = pd.concat(measurements)
 

diff --git a/tests/test_ddlpy.py b/tests/test_ddlpy.py
@@ -46,6 +46,14 @@ def test_measurements_amount(location):
     assert data_amount_jaar["Groeperingsperiode"].str.len().iloc[0] == 4
 
 
+def test_measurements_empty(location):
+    """measurements for a location """
+    start_date = dt.datetime(2153, 1, 1)
+    end_date = dt.datetime(2153, 1, 2)
+    measurements = ddlpy.measurements(location, start_date=start_date, end_date=end_date)
+    assert measurements.empty
+
+
 def test_measurements(location):
     """measurements for a location """
     start_date = dt.datetime(1953, 1, 1)