Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update predefined catalogs (deltares_data & artifact_data) #833

Merged
merged 134 commits into from
Jul 1, 2024
Merged

update predefined catalogs (deltares_data & artifact_data) #833

merged 134 commits into from
Jul 1, 2024

Conversation

DirkEilander
Copy link
Contributor

@DirkEilander DirkEilander commented Mar 7, 2024 •
edited by Tjalling-dejong
Loading

Issue addressed

Fixes #521 #701 #537

Also fixes #1007 because it was just a minor fix in the deltares_data catalogs.

Explanation

Explain how you addressed the bug/feature request, what choices you made and why.

Checklist

  • Updated tests or added new tests
  • Branch is up to date with main
  • Tests & pre-commit hooks pass
  • Updated documentation if needed
  • Updated changelog.rst if needed
  • For predefined catalogs: update the catalog version in the file itself, the references in data/predefined_catalogs.yml, and the changelog in data/changelog.rst

Additional Notes (optional)

Add any additional notes or information that may be helpful.

Tjalling-dejong and others added 30 commits November 9, 2023 17:08
@Tjalling-dejong
Updated first couple of datasets in deltares_data.yml datacatalog
3ed4bd3
@Tjalling-dejong
Added processing scripts/notes tags where necessary #356
d93f9a5
@Tjalling-dejong
Merge branch 'main' into improve_reproducibility_dd
1afa979
@Tjalling-dejong
Updated kwargs to driver_kwargs
4a9d791
@Tjalling-dejong
Updated deltares datacatalog with data version and added variants whe…
4c215db 
…re possible
@Tjalling-dejong
updated data catalog sources with version and where applicable variants
94ba815
@Tjalling-dejong
Added code for updating meta from variants
818002c
@Tjalling-dejong
updated tests for checking if meta is preserved for variants that hav…
66259fe 
…e their own meta
@Tjalling-dejong
removed source_version
9d6b346
@Tjalling-dejong
Updated predefined data catalog changelog
77c3055
@Tjalling-dejong
updated changelog
8d37459
@Tjalling-dejong
Merge branch 'main' into improve_reproducibility_dd
88ad4f8
@Tjalling-dejong
removed '*' era5 path in deltares data catalog and added check in dat…
efe622a 
…a adapter
@Tjalling-dejong
Added data_type to glofas_uparea
fe8ea5a
@Tjalling-dejong
merged dd_era5_quick_fix in branch
30aa581
@Tjalling-dejong
Set mollweide crs to ESRI:54009 otherwise will error
47f7fdc
@Tjalling-dejong
merged main into branch
a7af219
@Tjalling-dejong
fixed failing datacatalog validation tests
252dab3
@Tjalling-dejong
added temporal extent to deltares data
1817fbc
@Tjalling-dejong
updated changelog
2bab26b
@savente93
Merge branch 'main' into improve_reproducibility_dd
c79cc31
@Tjalling-dejong
added hydromt version to deltares_data
9a85eb3
@Tjalling-dejong
added hydromt versions to aws_data and gcs_cmip6_data data catalogs
2dc66f1
@Tjalling-dejong
Updated data catalog version
237579f
@Tjalling-dejong
updated changelog
dd80683
@Tjalling-dejong
Added spatial extent for raster datasets
cac2cf3
@Tjalling-dejong
Added spatial extents to geodataframe
c53b5c9
@Tjalling-dejong
updated data catalog changelog
9a9b6a9
@Tjalling-dejong
fixed merge conflict
0403192
@Tjalling-dejong
removed gtsm_codec_reanalysis dataset from deltares data catalog and …
9ad2aad 
…created a separate gtsm data catalog
@Tjalling-dejong Tjalling-dejong changed the base branch from main to v1 June 20, 2024 07:41
savente93
savente93 requested changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@savente93 savente93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, but there are a few things we'll need to address yet

docs/changelog.rst Outdated Show resolved Hide resolved
data/catalogs/artifact_data/v0.0.9/data_catalog.yml Show resolved Hide resolved
docs/api.rst Outdated Show resolved Hide resolved
data/catalogs/test_data_catalog.py Show resolved Hide resolved
docs/parse_predefined_catalogs.py Outdated Show resolved Hide resolved
docs/parse_predefined_catalogs.py Outdated Show resolved Hide resolved
savente93
savente93 approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@savente93 savente93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think it's all good now

@Tjalling-dejong Tjalling-dejong merged commit a0f435f into v1 Jul 1, 2024
8 checks passed
@Tjalling-dejong Tjalling-dejong deleted the improve_reproducibility_dd branch July 1, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tjalling-dejong Tjalling-dejong Tjalling-dejong left review comments

@hboisgon hboisgon hboisgon approved these changes

@savente93 savente93 savente93 approved these changes

Assignees

@Tjalling-dejong Tjalling-dejong

Labels
None yet
Projects
None yet
Milestone
No milestone
7 participants
@DirkEilander @savente93 @hboisgon @Tjalling-dejong @deltamarnix @roeldegoede @aweerts