You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have checked that this issue has not already been reported.
I have checked that this bug exists on the latest version.
Reproducible Example
The workflow for setting point cross-sections, which is used for cross-sections but also bridges and culverts, relies on the branches containing the columns ["frictionid", "frictiontype", "frictionvalue"]. In workflows.crosssections.py:
However, when a DFlowFM model is read using read_model, these attributes are not read, and only columns found in the branches.gui file are included. I looked at prepare_default_friction_and_crosssection() but I think it that we might be looking for something else
Current behaviour
When a model is read, no friction info is added to the branches. This info is used by other parts of the code
Desired behaviour
Either change workflows such that the friction info is not needed, or enhance model reading such that the friction of the branches can be inferred from a model. A possible (easy) solution is reading the branches geom, but this will then not work with DFlowFM models that are not built using hydromt_delft3dfm. Either way, I think there are multiple solutions and that therefore some extra thinking is required for finding the best solution
Additional context
No response
The text was updated successfully, but these errors were encountered:
See also the tests in #169 where this problem was found. Ideally, the tests of setup_bridges and setup_culverts should be able to run directly after reading the test model, without first calling the setup_channels method
Version checks
Reproducible Example
The workflow for setting point cross-sections, which is used for cross-sections but also bridges and culverts, relies on the branches containing the columns
["frictionid", "frictiontype", "frictionvalue"]
. In workflows.crosssections.py:hydromt_delft3dfm/hydromt_delft3dfm/workflows/crosssections.py
Lines 594 to 598 in 8862432
However, when a DFlowFM model is read using
read_model
, these attributes are not read, and only columns found in thebranches.gui
file are included. I looked atprepare_default_friction_and_crosssection()
but I think it that we might be looking for something elseCurrent behaviour
When a model is read, no friction info is added to the branches. This info is used by other parts of the code
Desired behaviour
Either change workflows such that the friction info is not needed, or enhance model reading such that the friction of the branches can be inferred from a model. A possible (easy) solution is reading the branches geom, but this will then not work with DFlowFM models that are not built using hydromt_delft3dfm. Either way, I think there are multiple solutions and that therefore some extra thinking is required for finding the best solution
Additional context
No response
The text was updated successfully, but these errors were encountered: