Fixes related to structures #169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
5 tasks
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Fixes #141 and some other small things
Explanation
Again, several bugfixes applied in the Santa Cruz branch, mostly related to duplicate structures and compound structures. This PR contains those fixes, and also some new tests for bridges and culverts.
Checklist
mainAdditional Notes
It currently does not include test cases checking if duplicate and compound structures are handled well which is something to include. For this, I think it can be a test only for the workflow and not the setup_methods which are already covered by the two new tests.
When developing the tests, I ran into some trouble, see #168 . This is addressed by also calling setup_channels in the test as a workaround, as I think this issue is too large to fit in this PR. I've included links to the issues in the tests as a reminder for us, and will also link the tests in the issue itself