Regular subgrid #160
Merged
Regular subgrid #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subgrid regular now also computes pwet etc. reads and writes to netcdf. sfincs may still need to be updated to account for this. subgrid quadtree added. still slow because no numba. both still need testing.
…t_sfincs into regular_subgrid
…ditions of subgrid netcdf and quadtree, so online subgrid v08 changes for regular grid remain
…o regular_subgrid
|
The new NETCDF subgrid for regular grids still needs some attention. I think that this branch https://github.com/Deltares/SFINCS/tree/netcdf_subgrid_reggrid is a step into the right direction, but we have to check whether those changes are needed. |
…o regular_subgrid
This was referenced Jan 9, 2024
Closed
|
@DirkEilander Can you have a look at the changes? We updated the subgrid formulations, changed the format from binary to netcdf and changed the keyword into nlevels instead of nbins. I'll add this to the changelog and update tests accordingly afterwards as well |
Co-authored-by: DirkEilander <[email protected]>
roeldegoede
reviewed
Mar 21, 2024
roeldegoede
reviewed
Mar 21, 2024
Comment on lines
+152
to
+153
| # TODO: check with Maarten whether this is meant to be different | ||
| # difference comes from different discretization of volume bins |
There was a problem hiding this comment.
@DirkEilander this is still something I would like to discuss with Maarten
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Fixes #159
Explanation
Copy paste code from quadtree_subgrid, without the quadtree part.
Bugfix leftover issues
Checklist
mainAdditional Notes (optional)
Add any additional notes or information that may be helpful.