Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix filter timeseries in setup_x_forcing #162

Merged
merged 4 commits into from
Dec 21, 2023
Merged

fix filter timeseries in setup_x_forcing #162

merged 4 commits into from
Dec 21, 2023

Conversation

DirkEilander
Copy link
Contributor

@DirkEilander DirkEilander commented Dec 20, 2023

Issue addressed

Fixes filtering of timeseries in case you have a large dataset in separate files for the timeseries and locations (rather than one geodataset). If the locations are filtered based on the model region a subset of the locations and all timeseries are passed to the set_1d_forcing method raising an error that the indices do not match.

Explanation

Add a filtering step after reading the location in setup_waterlevel_forcing and setup_discharge_forcing

Checklist

  • Updated tests or added new tests
  • Branch is up to date with main
  • Updated documentation if needed
  • Updated changelog.rst if needed

Additional Notes (optional)

Add any additional notes or information that may be helpful.

docs/changelog.rst Outdated Show resolved Hide resolved
@DirkEilander DirkEilander merged commit cc4c1eb into main Dec 21, 2023
4 checks passed
@DirkEilander DirkEilander deleted the fix_forcings branch December 21, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants