ENH: burn rivers in subgrid #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@roeldegoede I've made the final changes as discussed. Could you review these changes. And if you have time update the example (step 6 and 7). |
roeldegoede
approved these changes
Aug 3, 2023
hydromt_sfincs/subgrid.py
Outdated
| @@ -361,7 +370,7 @@ def build( | |||
|
|
|||
| # Count | |||
| ib += 1 | |||
| logger.debug( | |||
| logger.warning( | |||
There was a problem hiding this comment.
Do we want a warning here? This means it is always displayed right, before we had a logger.debug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
riv_datasetsto the setup_subgrid method to burn in rivers based on their width and depth.The example has been updated to show the setup_river_inflow together with this new functionality.