Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

Explicitly require locales to include them in Browserify build #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jfresco
Copy link

@jfresco jfresco commented Nov 6, 2015

@gvilarino
Copy link
Member

Any chance you use require-all for this? Not sure if it will work (depends on how browserify does) but it would definitely be awesome if you don't have to touch that file again every time you add/remove a language file.

@jfresco
Copy link
Author

jfresco commented Nov 9, 2015

@gvilarino Yes, it is possible. But, on the other hand, we are now putting in the bundle (app.js) all the languages that the app supports. If we do a require-all, we will also include all the languages that the app doesn't supports.
It's a trade-off between making the app.js bigger or the app more maintainable.
Opinions?

@mjlescano
Copy link
Member

We should think of a way for not delivering all the translations; too much size 🍰

captura de pantalla 2015-11-09 a las 10 37 17

@jfresco
Copy link
Author

jfresco commented Nov 9, 2015

@mjlescano Agree. It's not straightforward to do it with Browserify, as it puts in the bundle the modules that are explicitly required.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants