Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft of GitHub Actions #161

Merged
merged 23 commits into from
Feb 8, 2024
Merged

First draft of GitHub Actions #161

merged 23 commits into from
Feb 8, 2024

Conversation

kevinrue
Copy link
Collaborator

@kevinrue kevinrue commented Feb 2, 2024

No description provided.

Copy link
Collaborator

@bio-la bio-la left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me,
how is the action triggered in response to for example modifications to the ingestion tutorial yml ?

@kevinrue
Copy link
Collaborator Author

kevinrue commented Feb 7, 2024

Any commit pushed to the main branch or in a pull request to the main branch triggers this action.

@kevinrue
Copy link
Collaborator Author

kevinrue commented Feb 7, 2024

To clarify: any file edited in the repo, even if irrelevant to the ingestion tutorial triggers this workflow.

Basically, when we'll have multiple workflows, they will all be triggered when anything changes.

@bio-la
Copy link
Collaborator

bio-la commented Feb 8, 2024

the question is actually the other way around. any changes here (https://github.com/DendrouLab/panpipes) trigger the action.
but will changes in https://github.com/DendrouLab/panpipes-tutorials trigger the action here (on https://github.com/DendrouLab/panpipes) ?
i don't think so, am i missing something?

@kevinrue
Copy link
Collaborator Author

kevinrue commented Feb 8, 2024

Changes in the tutorial repo won't trigger the action, no.

It wouldn't make sense anyway, as the action doesn't run the contents of the tutorial repo itself, but rather my adaptation of it into a workflow in the YAML format required by GitHub actions.

@bio-la
Copy link
Collaborator

bio-la commented Feb 8, 2024

ok thanks for clarifying!
i think we can safely merge and this action will be the first check for this PR #158,
if something went wrong in panpipes ingest make config we should know (since @Lilly-May is modifying the pipeline.yml, this is the only part of the action that is affected by that PR)

@bio-la bio-la merged commit 3da8241 into main Feb 8, 2024
1 check passed
@kevinrue
Copy link
Collaborator Author

kevinrue commented Feb 8, 2024

Goes without saying but updating the input files on figshare also wouldn't trigger the action.

@kevinrue kevinrue deleted the kra-gha branch February 20, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants