pin version of recent breaking updates in dependencies #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bio-la |
|
Sorry: actually that means that we have a better idea of version requirements to define in the toml file, so that panpipes itself requires the correct version rather than users messing around their conda environment like I do in the GitHub action. |
|
Looks like I nailed the pyproject.toml file. Ready to merge as far as I'm concerned. Let me know if I missed anything! |
|
ah, matplotlib |
bio-la
approved these changes
Feb 9, 2024
| @@ -106,3 +115,9 @@ jobs: | |||
| - name: File tree | |||
| if: env.debug == 'true' | |||
| run: tree | |||
|
|
|||
| - uses: actions/upload-artifact@v4 | |||
There was a problem hiding this comment.
sorry, this is the ingestion action, why is there an "ingested" object already?
.github/workflows/ingestion-ci.yml
Outdated
| @@ -35,6 +35,20 @@ jobs: | |||
| activate-environment: pipeline_env | |||
| environment-file: pipeline_env.yaml # consider moving to etc/pipeline_env.yaml | |||
|
|
|||
| # Note: the pinned versions in pipeline_env.yaml are not respected during the miniconda step above | |||
| @@ -16,3 +16,13 @@ dependencies: | |||
| - pip: | |||
There was a problem hiding this comment.
do we need both pipeline_env.yml and ingestion-CI to pin the versions?
There was a problem hiding this comment.
I've removed the pins from the yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.