Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to accomodate different mem threads #210

Merged
merged 5 commits into from
Mar 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,13 @@
### fixed

- fixed error in `vis`
- error occurred when only wanting to plot continuous or categorical variables (or neither), not both
- error occurred when only wanting to plot continuous or categorical variables (or neither), not both
- fixed error in `refmap`
- high threads was not recognised, now fixed.

### dependencies
- All the dependencies have been updated.
- Python>=3.10 required

## v0.4.1

Expand Down
6 changes: 5 additions & 1 deletion docs/release_notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,13 @@
### fixed

- fixed error in `vis`
- error occurred when only wanting to plot continuous or categorical variables (or neither), not both
- error occurred when only wanting to plot continuous or categorical variables (or neither), not both
- fixed error in `refmap`
- high threads was not recognised, now fixed.

### dependencies
- All the dependencies have been updated.
- Python>=3.10 required

## v0.4.1

Expand Down
15 changes: 12 additions & 3 deletions panpipes/panpipes/pipeline_refmap.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from itertools import chain
import glob

# __file__="/well/cartography/users/zsj686/non_cart_projects/005-multimodal_scpipelines/src/sc_pipelines_muon_dev/panpipes/pipeline_refmap.py"

PARAMS = P.get_parameters(
["%s/pipeline.yml" % os.path.splitext(__file__)[0],
"pipeline.yml"])
Expand Down Expand Up @@ -104,7 +104,16 @@ def run_refmap_scvi(infile, outfile, log_file, ref_architecture ):
cmd += " --predict_rf %(run_randomforest)s"

cmd += " > %(log_file)s"
job_kwargs["job_threads"] = PARAMS['resources_threads_low']

if PARAMS['queues_gpu'] is not None:
job_kwargs["job_queue"] = PARAMS['queues_gpu']
job_kwargs["job_threads"] = int(PARAMS['resources_threads_gpu'])
elif PARAMS['queues_long'] is not None:
job_kwargs["job_queue"] = job_queue=PARAMS['queues_long']
job_kwargs["job_threads"] = int(PARAMS['resources_threads_high'])
else:
job_kwargs["job_threads"] = int(PARAMS['resources_threads_high'])

P.run(cmd, **job_kwargs)


Expand Down Expand Up @@ -150,7 +159,7 @@ def run_scib_refmap(infile,logfile):
if PARAMS['query_celltype'] is not None:
cmd += " --covariate %(query_celltype)s"
cmd += " > %(logfile)s"
job_kwargs["job_threads"] = PARAMS['resources_threads_medium']
job_kwargs["job_threads"] = PARAMS['resources_threads_high']
P.run(cmd, **job_kwargs)


Expand Down
2 changes: 1 addition & 1 deletion panpipes/panpipes/pipeline_refmap/pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ resources:
condaenv:

# allows for tweaking which queues jobs get submitted to,
# in case there is a special queue for long jobs or you have access to a gpu-sepcific queue
# in case there is a special queue for long jobs or you have access to a gpu-specific queue
# the default queue should be specified in your .cgat.yml file
# leave as is if you do not want to use the alternative queues
queues:
Expand Down