Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update run_filter.py #298

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Update run_filter.py #298

merged 1 commit into from
Aug 27, 2024

Conversation

deevdevil88
Copy link
Contributor

@deevdevil88 deevdevil88 commented Jul 25, 2024

There was an error in the for loop, the same variable wasnt being used across, leading to a mistake in the ncells counts per modality. as a stored mod variable from the previous for loop used durng filtering was being used instead. This leads to differences in cell numbers per sample_id per modality in the preprocess workflow output files output_prefix_cell_counts.csv and output_prefix_filtered_data.tsv. i wanted to thank @JHYSiu for finding this bug and flagging it. i have tested the change interactively in jupyter lab, and the ncell numbers per modality now match up with the preprocess object cel numbers.

Best,
Devika

There was an error in the for loop, the same variable wasnt being used acrsos, leading to mistake in the ncells counts.
@deevdevil88 deevdevil88 requested a review from bio-la July 25, 2024 18:23
@deevdevil88 deevdevil88 added the bug Something isn't working label Jul 25, 2024
@deevdevil88 deevdevil88 requested a review from JHYSiu July 25, 2024 18:24
@bio-la bio-la merged commit 3db4ccd into main Aug 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants