LSI-enabled BBKNN #301
Merged
LSI-enabled BBKNN #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bio-la
approved these changes
Aug 1, 2024
|
Hey @bio-la I think you committed your filled in yaml by accident. |
|
@wlason just adding a new CI to check that the integration does work as intended! (it's the one failing that uses the yaml you are pointing to) I need to fix it and then I'll merge the PR. |
bio-la
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option to run BBKNN with LSI, removed forced PC calculation for ATAC
Uses
dimredparameter from yaml to inform the choice of method (LSI/PCA). Default PCA.Will calculate PCA if no dimred method found.
This fixes #296 and rapidly decreases RAM needed to run.