Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dsb background #314

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Fix dsb background #314

merged 3 commits into from
Nov 27, 2024

Conversation

wlason
Copy link
Contributor

@wlason wlason commented Oct 15, 2024

  • Added check to ensure prot and rna is present in mods before dsb runs, exit if not
  • Added check to make sure only cells with prot information are retained in the background object (this caused an error for experimental designs where only a subset of cells has protein signal, not all)

Other intersection options (background object obs/unfiltered object obs, background object obs/filtered object obs) which were suggested are not good because they would remove empty droplets needed for dsb.

This fixes #1

@wlason wlason requested review from bio-la and deevdevil88 October 15, 2024 20:01
@wlason wlason marked this pull request as ready for review October 15, 2024 20:11
@bio-la
Copy link
Collaborator

bio-la commented Oct 16, 2024

awesome! i will check the refmap action and merge this PR.

@bio-la bio-la merged commit b3c3262 into main Nov 27, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dsb does not run when intersection is False
3 participants