Add Run option params LISI and SCIB metrics for pipeline_integration.py #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added an active_if Run option for scib and LISI
added `run` params for LISI and SCIB
deevdevil88
requested review from
Lilly-May,
bio-la and
wlason
and removed request for
Lilly-May
bio-la
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in issues#320, i have added a
runparameter for LISI and scib metrics. As sciB might fail on smaller datasets, but LISI sometimes takes hours on very bi datasets too and not everyone wants to run it. On default both are set asTruebut users can change toFalseif they want.